better skip

aduh95 · aduh95 · commit 29607a1e5f48 · 2024-05-11T10:42:17.000+02:00
diff --git a/test/common/index.js b/test/common/index.js
@@ -603,7 +603,8 @@ function printSkipMessage(msg) {
 
 function skip(msg) {
   printSkipMessage(msg);
-  process.exit(0);
+  // In known_issues test, skipping should produce a non-zero exit code.
+  process.exit(require.main?.filename.startsWith(path.resolve(__dirname, '../known_issues/')) ? 1 : 0);
 }
 
 // Returns true if the exit code "exitCode" and/or signal name "signal"

Original file line number	Diff line number	Diff line change
`@@ -603,7 +603,8 @@ function printSkipMessage(msg) {`
`603`	`603`
`604`	`604`	`function skip(msg) {`
`605`	`605`	`printSkipMessage(msg);`
`606`		`- process.exit(0);`
	`606`	`+ // In known_issues test, skipping should produce a non-zero exit code.`
	`607`	`+ process.exit(require.main?.filename.startsWith(path.resolve(__dirname, '../known_issues/')) ? 1 : 0);`
`607`	`608`	`}`
`608`	`609`
`609`	`610`	`// Returns true if the exit code "exitCode" and/or signal name "signal"`