Skip to content

Commit 297773c

Browse files
deokjinkimjuanarbol
authored andcommitted
events: change status of event.returnvalue to legacy
`event.returnvalue` is described as legacy in spec. Plus, add missed '#'(private member) of defaultPrevented in implementation. Refs: https://dom.spec.whatwg.org/#interface-event Refs: https://developer.mozilla.org/en-US/docs/Web/API/Event/returnValue PR-URL: #46175 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 parent a3056f4 commit 297773c

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

doc/api/events.md

+4
Original file line numberDiff line numberDiff line change
@@ -2111,8 +2111,11 @@ Sets the `defaultPrevented` property to `true` if `cancelable` is `true`.
21112111
added: v14.5.0
21122112
-->
21132113

2114+
> Stability: 3 - Legacy: Use [`event.defaultPrevented`][] instead.
2115+
21142116
* Type: {boolean} True if the event has not been canceled.
21152117

2118+
The value of `event.returnValue` is always the opposite of `event.defaultPrevented`.
21162119
This is not used in Node.js and is provided purely for completeness.
21172120

21182121
#### `event.srcElement`
@@ -2429,6 +2432,7 @@ to the `EventTarget`.
24292432
[`emitter.listenerCount()`]: #emitterlistenercounteventname
24302433
[`emitter.removeListener()`]: #emitterremovelistenereventname-listener
24312434
[`emitter.setMaxListeners(n)`]: #emittersetmaxlistenersn
2435+
[`event.defaultPrevented`]: #eventdefaultprevented
24322436
[`event.stopPropagation()`]: #eventstoppropagation
24332437
[`event.target`]: #eventtarget
24342438
[`events.defaultMaxListeners`]: #eventsdefaultmaxlisteners

lib/internal/event_target.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ class Event {
236236
get returnValue() {
237237
if (!isEvent(this))
238238
throw new ERR_INVALID_THIS('Event');
239-
return !this.defaultPrevented;
239+
return !this.#cancelable || !this.#defaultPrevented;
240240
}
241241

242242
/**

0 commit comments

Comments
 (0)