Skip to content

Commit 2b1e7c2

Browse files
StefanStojanovicRafaelGSS
authored andcommitted
build: compile with C++20 support on Windows
Our Linux build infra is not ready for it yet, but V8 is making it difficult to compile on Windows without it. Refs: #45402 PR-URL: #52465 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
1 parent 5bde9e6 commit 2b1e7c2

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

common.gypi

+2-1
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,8 @@
286286
'VCCLCompilerTool': {
287287
'AdditionalOptions': [
288288
'/Zc:__cplusplus',
289-
'-std:c++17'
289+
# The following option enables c++20 on Windows. This is needed for V8 v12.4+
290+
'-std:c++20',
290291
],
291292
'BufferSecurityCheck': 'true',
292293
'DebugInformationFormat': 1, # /Z7 embed info in .obj files

0 commit comments

Comments
 (0)