Skip to content

Commit 2dfaa48

Browse files
cjihrigBridgeAR
authored andcommitted
dns: simplify dns.promises warning logic
dns.promises is lazy loaded. Instead of using a seaparate Boolean flag to track whether or not it has been loaded, just inspect the state of the lazy loaded module itself. PR-URL: #24788 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
1 parent 124fca0 commit 2dfaa48

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

lib/dns.js

+3-5
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,7 @@ const {
5050

5151
const dnsException = errors.dnsException;
5252

53-
let promisesWarn = true;
54-
let promises; // Lazy loaded
53+
let promises = null; // Lazy loaded
5554

5655
function onlookup(err, addresses) {
5756
if (err) {
@@ -269,7 +268,7 @@ function defaultResolverSetServers(servers) {
269268
setDefaultResolver(resolver);
270269
bindDefaultResolver(module.exports, Resolver.prototype);
271270

272-
if (promises !== undefined)
271+
if (promises !== null)
273272
bindDefaultResolver(promises, promises.Resolver.prototype);
274273
}
275274

@@ -318,10 +317,9 @@ Object.defineProperties(module.exports, {
318317
configurable: true,
319318
enumerable: false,
320319
get() {
321-
if (promisesWarn) {
320+
if (promises === null) {
322321
promises = require('internal/dns/promises');
323322
promises.setServers = defaultResolverSetServers;
324-
promisesWarn = false;
325323
process.emitWarning('The dns.promises API is experimental',
326324
'ExperimentalWarning');
327325
}

0 commit comments

Comments
 (0)