Skip to content

Commit 2e2c09e

Browse files
bwhittyMylesBorins
authored andcommitted
test: more AsyncWrap constructor validation tests
Fixes a line of uncovered code in the AsyncWrap class's constructor. Specifically this covers validtion of the 'promiseResolve' argument. PR-URL: #16025 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
1 parent 6f5edf4 commit 2e2c09e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

test/parallel/test-async-wrap-constructor.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ const assert = require('assert');
77
const async_hooks = require('async_hooks');
88

99
for (const badArg of [0, 1, false, true, null, 'hello']) {
10-
for (const field of ['init', 'before', 'after', 'destroy']) {
10+
const hookNames = ['init', 'before', 'after', 'destroy', 'promiseResolve'];
11+
for (const field of hookNames) {
1112
assert.throws(() => {
1213
async_hooks.createHook({ [field]: badArg });
1314
}, common.expectsError({

0 commit comments

Comments
 (0)