Skip to content

Commit 3066f2c

Browse files
committed
test: double test timeout on arm machines
The ARM buildbots are notoriously slow. Update the test runner to double the per-test time limit when it's running on one of them. PR-URL: #1357 Reviewed-By: Roman Reiss <me@silverwind.io>
1 parent 372bf83 commit 3066f2c

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

tools/test.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -729,8 +729,8 @@ def GetTestStatus(self, context, sections, defs):
729729
'debug' : ['--enable-slow-asserts', '--debug-code', '--verify-heap'],
730730
'release' : []}
731731
TIMEOUT_SCALEFACTOR = {
732-
'debug' : 4,
733-
'release' : 1 }
732+
'arm' : { 'debug' : 8, 'release' : 2 }, # The ARM buildbots are slow.
733+
'ia32' : { 'debug' : 4, 'release' : 1 } }
734734

735735

736736
class Context(object):
@@ -770,7 +770,7 @@ def GetVmFlags(self, testcase, mode):
770770
return testcase.variant_flags + FLAGS[mode]
771771

772772
def GetTimeout(self, mode):
773-
return self.timeout * TIMEOUT_SCALEFACTOR[mode]
773+
return self.timeout * TIMEOUT_SCALEFACTOR[ARCH_GUESS or 'ia32'][mode]
774774

775775
def RunTestCases(cases_to_run, progress, tasks):
776776
progress = PROGRESS_INDICATORS[progress](cases_to_run)

tools/utils.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ def GuessOS():
7373
def GuessArchitecture():
7474
id = platform.machine()
7575
id = id.lower() # Windows 7 capitalizes 'AMD64'.
76-
if id.startswith('arm'):
76+
if id.startswith('arm') or id == 'aarch64':
7777
return 'arm'
7878
elif (not id) or (not re.match('(x|i[3-6])86$', id) is None):
7979
return 'ia32'

0 commit comments

Comments
 (0)