Skip to content

Commit 307e43d

Browse files
nimit95BethGriggs
authored andcommitted
src: elevate v8 namespaces
elevate v8 namespaces. Leverage `using` semantics for repeated usage of v8 artifacts. PR-URL: #32872 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Zeyu Yang <himself65@outlook.com>
1 parent 22ccf2b commit 307e43d

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/cares_wrap.cc

+2-1
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ using v8::Int32;
6666
using v8::Integer;
6767
using v8::Isolate;
6868
using v8::Local;
69+
using v8::NewStringType;
6970
using v8::Null;
7071
using v8::Object;
7172
using v8::String;
@@ -1929,7 +1930,7 @@ void CanonicalizeIP(const FunctionCallbackInfo<Value>& args) {
19291930
const int af = (rc == 4 ? AF_INET : AF_INET6);
19301931
CHECK_EQ(0, uv_inet_ntop(af, &result, canonical_ip, sizeof(canonical_ip)));
19311932
Local<String> val = String::NewFromUtf8(isolate, canonical_ip,
1932-
v8::NewStringType::kNormal).ToLocalChecked();
1933+
NewStringType::kNormal).ToLocalChecked();
19331934
args.GetReturnValue().Set(val);
19341935
}
19351936

src/env.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -174,10 +174,10 @@ void IsolateData::CreateProperties() {
174174
#define V(Provider) \
175175
async_wrap_providers_[AsyncWrap::PROVIDER_ ## Provider].Set( \
176176
isolate_, \
177-
v8::String::NewFromOneByte( \
177+
String::NewFromOneByte( \
178178
isolate_, \
179179
reinterpret_cast<const uint8_t*>(#Provider), \
180-
v8::NewStringType::kInternalized, \
180+
NewStringType::kInternalized, \
181181
sizeof(#Provider) - 1).ToLocalChecked());
182182
NODE_ASYNC_PROVIDER_TYPES(V)
183183
#undef V

0 commit comments

Comments
 (0)