Skip to content

Commit 309c395

Browse files
cclausstargos
authored andcommitted
tools: undefined name opts -> args in gyptest.py
``` ./tools/gyp/gyptest.py:61:47: F821 undefined name 'opts' extra_path = [os.path.abspath(p) for p in opts.path] ^ ``` `opts.path` is an undefined name in this context while `args.path` is used on the preceding line and is defined on line 48. Undefined names have the potential to raise `NameError` at runtime which will halt the script. PR-URL: #30144 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
1 parent 6bc7a6d commit 309c395

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/gyp/gyptest.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def main(argv=None):
5858
os.chdir(args.chdir)
5959

6060
if args.path:
61-
extra_path = [os.path.abspath(p) for p in opts.path]
61+
extra_path = [os.path.abspath(p) for p in args.path]
6262
extra_path = os.pathsep.join(extra_path)
6363
os.environ['PATH'] = extra_path + os.pathsep + os.environ['PATH']
6464

0 commit comments

Comments
 (0)