Skip to content

Commit 30c4e1d

Browse files
committed
tools: update V8 gypfiles for 9.8
PR-URL: #41610 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent aa7dc80 commit 30c4e1d

File tree

3 files changed

+7
-13
lines changed

3 files changed

+7
-13
lines changed

tools/v8_gypfiles/features.gypi

+5-6
Original file line numberDiff line numberDiff line change
@@ -151,9 +151,6 @@
151151
# into relaxed atomic operations.
152152
'v8_enable_atomic_object_field_writes%': 1,
153153

154-
# Sets -dV8_ATOMIC_MARKING_STATE
155-
'v8_enable_atomic_marking_state%': 1,
156-
157154
# Has no effect in Node.js. Here for completeness with V8's config.
158155
'v8_enable_concurrent_marking%': 1,
159156

@@ -236,6 +233,8 @@
236233

237234
'v8_scriptormodule_legacy_lifetime%': 1,
238235

236+
'v8_include_receiver_in_argc%': 1,
237+
239238
# Variables from v8.gni
240239

241240
# Enable ECMAScript Internationalization API. Enabling this feature will
@@ -358,9 +357,6 @@
358357
['v8_enable_atomic_object_field_writes==1', {
359358
'defines': ['V8_ATOMIC_OBJECT_FIELD_WRITES',],
360359
}],
361-
['v8_enable_atomic_marking_state==1', {
362-
'defines': ['V8_ATOMIC_MARKING_STATE',],
363-
}],
364360
['v8_enable_lazy_source_positions==1', {
365361
'defines': ['V8_ENABLE_LAZY_SOURCE_POSITIONS',],
366362
}],
@@ -412,6 +408,9 @@
412408
['v8_advanced_bigint_algorithms==1', {
413409
'defines': ['V8_ADVANCED_BIGINT_ALGORITHMS',],
414410
}],
411+
['v8_include_receiver_in_argc==1', {
412+
'defines': ['V8_INCLUDE_RECEIVER_IN_ARGC',],
413+
}],
415414
], # conditions
416415
'defines': [
417416
'V8_GYP_BUILD',

tools/v8_gypfiles/toolchain.gypi

+1
Original file line numberDiff line numberDiff line change
@@ -978,6 +978,7 @@
978978
'defines': [
979979
'WIN32',
980980
'NOMINMAX', # Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1456620
981+
'_WIN32_WINNT=0x0602', # Windows 8
981982
],
982983
# 4351: VS 2005 and later are warning us that they've fixed a bug
983984
# present in VS 2003 and earlier.

tools/v8_gypfiles/v8.gyp

+1-7
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,11 @@
8787
"<(SHARED_INTERMEDIATE_DIR)/torque-generated/exported-macros-assembler.h",
8888
"<(SHARED_INTERMEDIATE_DIR)/torque-generated/factory.cc",
8989
"<(SHARED_INTERMEDIATE_DIR)/torque-generated/factory.inc",
90-
"<(SHARED_INTERMEDIATE_DIR)/torque-generated/field-offsets.h",
9190
"<(SHARED_INTERMEDIATE_DIR)/torque-generated/instance-types.h",
9291
"<(SHARED_INTERMEDIATE_DIR)/torque-generated/interface-descriptors.inc",
9392
"<(SHARED_INTERMEDIATE_DIR)/torque-generated/objects-body-descriptors-inl.inc",
9493
"<(SHARED_INTERMEDIATE_DIR)/torque-generated/objects-printer.cc",
94+
"<(SHARED_INTERMEDIATE_DIR)/torque-generated/visitor-lists.h",
9595
'<@(torque_outputs_csa_cc)',
9696
'<@(torque_outputs_csa_h)',
9797
'<@(torque_outputs_inl_inc)',
@@ -1135,11 +1135,6 @@
11351135
'<(V8_ROOT)/src/base/platform/platform-win32.cc',
11361136
'<(V8_ROOT)/src/base/win32-headers.h',
11371137
],
1138-
'conditions': [
1139-
['target_arch == "arm64"', {
1140-
'defines': ['_WIN32_WINNT=0x0602'], # For GetCurrentThreadStackLimits on Windows on Arm
1141-
}],
1142-
],
11431138
'defines': ['_CRT_RAND_S'], # for rand_s()
11441139
'direct_dependent_settings': {
11451140
'msvs_settings': {
@@ -1733,7 +1728,6 @@
17331728
'is_ubsan_vptr=0',
17341729
'target_cpu=<(target_arch)',
17351730
'v8_current_cpu=<(v8_current_cpu)',
1736-
'v8_enable_atomic_marking_state=<(v8_enable_atomic_marking_state)',
17371731
'v8_enable_atomic_object_field_writes=<(v8_enable_atomic_object_field_writes)',
17381732
'v8_enable_concurrent_marking=<(v8_enable_concurrent_marking)',
17391733
'v8_enable_i18n_support=<(v8_enable_i18n_support)',

0 commit comments

Comments
 (0)