Skip to content

Commit 3294d1b

Browse files
committed
src: remove --expose-http2 option
This commit removes the --expose-http2 option. In the code comment it states that this should should be noop through v9.x, and it sounds like it can be removed for 10.x and above. PR-URL: #20887 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 9a02de7 commit 3294d1b

File tree

6 files changed

+4
-9
lines changed

6 files changed

+4
-9
lines changed

benchmark/http2/headers.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const bench = common.createBenchmark(main, {
77
n: [1e3],
88
nheaders: [0, 10, 100, 1000],
99
benchmarker: ['h2load']
10-
}, { flags: ['--no-warnings', '--expose-http2'] });
10+
}, { flags: ['--no-warnings'] });
1111

1212
function main({ n, nheaders }) {
1313
const http2 = require('http2');

benchmark/http2/respond-with-fd.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const bench = common.createBenchmark(main, {
1111
streams: [100, 200, 1000],
1212
clients: [1, 2],
1313
benchmarker: ['h2load']
14-
}, { flags: ['--no-warnings', '--expose-http2'] });
14+
}, { flags: ['--no-warnings'] });
1515

1616
function main({ requests, streams, clients }) {
1717
fs.open(file, 'r', (err, fd) => {

benchmark/http2/simple.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const bench = common.createBenchmark(main, {
1010
streams: [100, 200, 1000],
1111
clients: [1, 2],
1212
benchmarker: ['h2load']
13-
}, { flags: ['--no-warnings', '--expose-http2'] });
13+
}, { flags: ['--no-warnings'] });
1414

1515
function main({ requests, streams, clients }) {
1616
const http2 = require('http2');

benchmark/http2/write.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const bench = common.createBenchmark(main, {
77
length: [64 * 1024, 128 * 1024, 256 * 1024, 1024 * 1024],
88
size: [100000],
99
benchmarker: ['h2load']
10-
}, { flags: ['--no-warnings', '--expose-http2'] });
10+
}, { flags: ['--no-warnings'] });
1111

1212
function main({ streams, length, size }) {
1313
const http2 = require('http2');

src/node.cc

-4
Original file line numberDiff line numberDiff line change
@@ -3358,7 +3358,6 @@ static void CheckIfAllowedInEnv(const char* exe, bool is_env,
33583358
"--experimental-modules",
33593359
"--experimental-repl-await",
33603360
"--experimental-vm-modules",
3361-
"--expose-http2", // keep as a non-op through v9.x
33623361
"--force-fips",
33633362
"--icu-data-dir",
33643363
"--inspect",
@@ -3608,9 +3607,6 @@ static void ParseArgs(int* argc,
36083607
} else if (strcmp(arg, "--expose-internals") == 0 ||
36093608
strcmp(arg, "--expose_internals") == 0) {
36103609
config_expose_internals = true;
3611-
} else if (strcmp(arg, "--expose-http2") == 0 ||
3612-
strcmp(arg, "--expose_http2") == 0) {
3613-
// Keep as a non-op through v9.x
36143610
} else if (strcmp(arg, "-") == 0) {
36153611
break;
36163612
} else if (strcmp(arg, "--") == 0) {

test/parallel/test-http2-https-fallback-http-server-options.js

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// Flags: --expose-http2
21
'use strict';
32

43
const common = require('../common');

0 commit comments

Comments
 (0)