Skip to content

Commit 339c192

Browse files
committedMar 18, 2020
src: update NODE_MODULE_VERSION to 83
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 8.1. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: #32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent da92f15 commit 339c192

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed
 

‎doc/abi_version_registry.json

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"NODE_MODULE_VERSION": [
3+
{ "modules": 83, "runtime": "node", "variant": "v8_8.1", "versions": "14.0.0-pre" },
34
{ "modules": 82, "runtime": "electron", "variant": "electron", "versions": "10" },
45
{ "modules": 81, "runtime": "node", "variant": "v8_7.9", "versions": "14.0.0-pre" },
56
{ "modules": 80, "runtime": "electron", "variant": "electron", "versions": "9" },

‎src/node_version.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@
8989
* version matching should open a pull request to reserve a number in this
9090
* registry.
9191
*/
92-
#define NODE_MODULE_VERSION 81
92+
#define NODE_MODULE_VERSION 83
9393

9494
// The NAPI_VERSION provided by this version of the runtime. This is the version
9595
// which the Node binary being built supports.

0 commit comments

Comments
 (0)
Please sign in to comment.