Skip to content

Commit 33e2ee5

Browse files
benjamingrdanielleadams
authored andcommitted
events: define event handler as enumerable
PR-URL: #35931 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 7a2edea commit 33e2ee5

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

lib/internal/event_target.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -592,7 +592,9 @@ function defineEventHandler(emitter, name) {
592592
emitter.addEventListener(name, value);
593593
}
594594
eventHandlerValue = value;
595-
}
595+
},
596+
configurable: true,
597+
enumerable: true
596598
});
597599
}
598600
module.exports = {

test/parallel/test-eventtarget.js

+7
Original file line numberDiff line numberDiff line change
@@ -517,3 +517,10 @@ let asyncTest = Promise.resolve();
517517
}));
518518
target.dispatchEvent(new Event('foo'));
519519
}
520+
{
521+
const target = new EventTarget();
522+
defineEventHandler(target, 'foo');
523+
const descriptor = Object.getOwnPropertyDescriptor(target, 'onfoo');
524+
strictEqual(descriptor.configurable, true);
525+
strictEqual(descriptor.enumerable, true);
526+
}

0 commit comments

Comments
 (0)