Skip to content

Commit 34165f0

Browse files
committed
quic: resolve some minor TODOs
PR-URL: #34655 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 1e6e5c3 commit 34165f0

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

lib/internal/quic/core.js

-2
Original file line numberDiff line numberDiff line change
@@ -517,7 +517,6 @@ function createSecureContext(options, init_cb) {
517517
const sc_options = validateCreateSecureContextOptions(options);
518518
const { groups, earlyData } = sc_options;
519519
const sc = _createSecureContext(sc_options);
520-
// TODO(@jasnell): Determine if it's really necessary to pass in groups here.
521520
init_cb(sc.context, groups, earlyData);
522521
return sc;
523522
}
@@ -2702,7 +2701,6 @@ class QuicStream extends Duplex {
27022701
}
27032702

27042703
[kInspect](depth, options) {
2705-
// TODO(@jasnell): Proper custom inspect implementation
27062704
const direction = this.bidirectional ? 'bidirectional' : 'unidirectional';
27072705
const initiated = this.serverInitiated ? 'server' : 'client';
27082706
return customInspect(this, {

src/quic/node_quic_session.cc

+5-4
Original file line numberDiff line numberDiff line change
@@ -3378,8 +3378,10 @@ int QuicSession::OnStreamReset(
33783378
// sensitivity of PATH_CHALLENGE operations (an attacker
33793379
// could use a compromised PATH_CHALLENGE to trick an endpoint
33803380
// into redirecting traffic).
3381-
// TODO(@jasnell): In the future, we'll want to explore whether
3382-
// we want to handle the different cases of ngtcp2_rand_ctx
3381+
//
3382+
// The ngtcp2_rand_ctx tells us what the random data is used for.
3383+
// Currently, there is only one use. In the future, we'll want to
3384+
// explore whether we want to handle the different cases uses.
33833385
int QuicSession::OnRand(
33843386
ngtcp2_conn* conn,
33853387
uint8_t* dest,
@@ -3744,8 +3746,7 @@ void QuicSessionSilentClose(const FunctionCallbackInfo<Value>& args) {
37443746
session->Close(QuicSessionListener::SESSION_CLOSE_FLAG_SILENT);
37453747
}
37463748

3747-
// TODO(addaleax): This is a temporary solution for testing and should be
3748-
// removed later.
3749+
// This is used purely for testing.
37493750
void QuicSessionRemoveFromSocket(const FunctionCallbackInfo<Value>& args) {
37503751
QuicSession* session;
37513752
ASSIGN_OR_RETURN_UNWRAP(&session, args.Holder());

0 commit comments

Comments
 (0)