File tree 2 files changed +5
-6
lines changed
2 files changed +5
-6
lines changed Original file line number Diff line number Diff line change @@ -517,7 +517,6 @@ function createSecureContext(options, init_cb) {
517
517
const sc_options = validateCreateSecureContextOptions ( options ) ;
518
518
const { groups, earlyData } = sc_options ;
519
519
const sc = _createSecureContext ( sc_options ) ;
520
- // TODO(@jasnell): Determine if it's really necessary to pass in groups here.
521
520
init_cb ( sc . context , groups , earlyData ) ;
522
521
return sc ;
523
522
}
@@ -2702,7 +2701,6 @@ class QuicStream extends Duplex {
2702
2701
}
2703
2702
2704
2703
[ kInspect ] ( depth , options ) {
2705
- // TODO(@jasnell): Proper custom inspect implementation
2706
2704
const direction = this . bidirectional ? 'bidirectional' : 'unidirectional' ;
2707
2705
const initiated = this . serverInitiated ? 'server' : 'client' ;
2708
2706
return customInspect ( this , {
Original file line number Diff line number Diff line change @@ -3378,8 +3378,10 @@ int QuicSession::OnStreamReset(
3378
3378
// sensitivity of PATH_CHALLENGE operations (an attacker
3379
3379
// could use a compromised PATH_CHALLENGE to trick an endpoint
3380
3380
// into redirecting traffic).
3381
- // TODO(@jasnell): In the future, we'll want to explore whether
3382
- // we want to handle the different cases of ngtcp2_rand_ctx
3381
+ //
3382
+ // The ngtcp2_rand_ctx tells us what the random data is used for.
3383
+ // Currently, there is only one use. In the future, we'll want to
3384
+ // explore whether we want to handle the different cases uses.
3383
3385
int QuicSession::OnRand (
3384
3386
ngtcp2_conn* conn,
3385
3387
uint8_t * dest,
@@ -3744,8 +3746,7 @@ void QuicSessionSilentClose(const FunctionCallbackInfo<Value>& args) {
3744
3746
session->Close (QuicSessionListener::SESSION_CLOSE_FLAG_SILENT);
3745
3747
}
3746
3748
3747
- // TODO(addaleax): This is a temporary solution for testing and should be
3748
- // removed later.
3749
+ // This is used purely for testing.
3749
3750
void QuicSessionRemoveFromSocket (const FunctionCallbackInfo<Value>& args) {
3750
3751
QuicSession* session;
3751
3752
ASSIGN_OR_RETURN_UNWRAP (&session, args.Holder ());
You can’t perform that action at this time.
0 commit comments