Add comment to explain the use of shallow copying here

malthe · malthe · commit 352a55685c35 · 2024-02-27T09:08:09.000+01:00
diff --git a/lib/internal/test_runner/reporter/tap.js b/lib/internal/test_runner/reporter/tap.js
@@ -224,6 +224,9 @@ function jsToYaml(indent, name, value, seen) {
     }
 
     if (errIsAssertion) {
+      // Note that we're deliberately creating shallow copies of the `seen`
+      // set here in order to isolate the discovery of circular references
+      // within the expected and actual properties respectively.
       result += jsToYaml(indent, 'expected', errExpected, new SafeSet(seen));
       result += jsToYaml(indent, 'actual', errActual, new SafeSet(seen));
       if (errOperator) {

Original file line number	Diff line number	Diff line change
`@@ -224,6 +224,9 @@ function jsToYaml(indent, name, value, seen) {`
`224`	`224`	`}`
`225`	`225`
`226`	`226`	`if (errIsAssertion) {`
	`227`	+ // Note that we're deliberately creating shallow copies of the `seen`
	`228`	`+ // set here in order to isolate the discovery of circular references`
	`229`	`+ // within the expected and actual properties respectively.`
`227`	`230`	`result += jsToYaml(indent, 'expected', errExpected, new SafeSet(seen));`
`228`	`231`	`result += jsToYaml(indent, 'actual', errActual, new SafeSet(seen));`
`229`	`232`	`if (errOperator) {`