Skip to content

Commit 3816a97

Browse files
mhdawsonBethGriggs
authored andcommitted
doc: add detail for how to update llhttp
Add detail on how to update llhttp in deps to the guide for maintaining http. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #43028 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 8e54c19 commit 3816a97

File tree

1 file changed

+28
-2
lines changed

1 file changed

+28
-2
lines changed

β€Ždoc/contributing/maintaining-http.md

+28-2
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,35 @@ to align them with the APIs built for the client.
7474
The low-level implementation of the
7575
[HTTP](https://nodejs.org/docs/latest/api/http.html)
7676
and [HTTPS](https://nodejs.org/docs/latest/api/https.html) APIs
77-
are maintained in the [llttp](https://github.com/nodejs/llhttp)
77+
are maintained in the [llhttp](https://github.com/nodejs/llhttp)
7878
repository. Updates are pulled into Node.js under
79-
[deps/llhttp](https://github.com/nodejs/node/tree/HEAD/deps/llhttp)
79+
[deps/llhttp](https://github.com/nodejs/node/tree/HEAD/deps/llhttp).
80+
81+
In order to update Node.js with a new version of llhttp:
82+
83+
* check out the tagged release that you want to update to (a release
84+
should be created in the llhttp repo before updating Node.js).
85+
* run `npm install` in the directory that you checked out llhttp.
86+
* run `make release` in the directory that you checked out llhttp.
87+
* copy the contents of the `release` directory from the directory you
88+
checked llhttp out to
89+
[deps/llhttp](https://github.com/nodejs/node/tree/HEAD/deps/llhttp)
90+
91+
It should look like the following:
92+
93+
```console
94+
β”œβ”€β”€ CMakeLists.txt
95+
β”œβ”€β”€ common.gypi
96+
β”œβ”€β”€ include
97+
β”‚ └── llhttp.h
98+
β”œβ”€β”€ LICENSE-MIT
99+
β”œβ”€β”€ llhttp.gyp
100+
β”œβ”€β”€ README.md
101+
└── src
102+
β”œβ”€β”€ api.c
103+
β”œβ”€β”€ http.c
104+
└── llhttp.c
105+
```
80106

81107
The low-level implementation is made available in the Node.js API through
82108
JavaScript code in the [lib](https://github.com/nodejs/node/tree/HEAD/lib)

0 commit comments

Comments
Β (0)