Skip to content

Commit 3837c8d

Browse files
authored
build: fix GN build on macOS
use_gold is not defined on macOS. PR-URL: #56141 Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Jason Zhang <xzha4350@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
1 parent dbfcbe3 commit 3837c8d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

unofficial.gni

+1-1
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ template("node_gn_build") {
263263
ldflags = [ "/OPT:NOICF" ] # link.exe, but also lld-link.exe.
264264
} else if (is_apple && !use_lld) {
265265
ldflags = [ "-Wl,-no_deduplicate" ] # ld64.
266-
} else if (use_gold || use_lld) {
266+
} else if ((!is_apple && use_gold) || use_lld) {
267267
ldflags = [ "-Wl,--icf=none" ]
268268
}
269269
}

0 commit comments

Comments
 (0)