Skip to content

Commit 3ab391d

Browse files
apapirovskievanlucas
authored andcommitted
src: remove unnecessary block scope
PR-URL: #18291 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 799fd24 commit 3ab391d

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

src/node.cc

+6-10
Original file line numberDiff line numberDiff line change
@@ -1379,17 +1379,13 @@ MaybeLocal<Value> InternalMakeCallback(Environment* env,
13791379
return Undefined(env->isolate());
13801380
}
13811381

1382-
MaybeLocal<Value> ret;
1382+
MaybeLocal<Value> ret = callback->Call(env->context(), recv, argc, argv);
13831383

1384-
{
1385-
ret = callback->Call(env->context(), recv, argc, argv);
1386-
1387-
if (ret.IsEmpty()) {
1388-
// NOTE: For backwards compatibility with public API we return Undefined()
1389-
// if the top level call threw.
1390-
scope.MarkAsFailed();
1391-
return scope.IsInnerMakeCallback() ? ret : Undefined(env->isolate());
1392-
}
1384+
if (ret.IsEmpty()) {
1385+
// NOTE: For backwards compatibility with public API we return Undefined()
1386+
// if the top level call threw.
1387+
scope.MarkAsFailed();
1388+
return scope.IsInnerMakeCallback() ? ret : Undefined(env->isolate());
13931389
}
13941390

13951391
scope.Close();

0 commit comments

Comments
 (0)