Skip to content

Commit 3acba1d

Browse files
jasnelldanielleadams
authored andcommitted
events: remove return value on addEventListener
The `addEventListener()` should not return a value. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37696 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent efd14a9 commit 3acba1d

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

lib/internal/event_target.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ class EventTarget {
329329

330330
if (signal) {
331331
if (signal.aborted) {
332-
return false;
332+
return;
333333
}
334334
// TODO(benjamingr) make this weak somehow? ideally the signal would
335335
// not prevent the event target from GC.

test/parallel/test-eventtarget-whatwg-signal.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,11 @@ const {
2525
controller.abort();
2626
et.dispatchEvent(new Event('test'));
2727
strictEqual(count, 2, 'Aborting on the controller removes the listener');
28-
et.addEventListener('test', handler, { signal: controller.signal });
28+
// See: https://github.com/nodejs/node/pull/37696 , adding an event listener
29+
// should always return undefined.
30+
strictEqual(
31+
et.addEventListener('test', handler, { signal: controller.signal }),
32+
undefined);
2933
et.dispatchEvent(new Event('test'));
3034
strictEqual(count, 2, 'Passing an aborted signal never adds the handler');
3135
}

0 commit comments

Comments
 (0)