Skip to content

Commit 3b64fa4

Browse files
bnoordhuisgibfahn
authored andcommitted
build: fix npm install with --shared
The npm install rules had a hidden dependency on the `node` binary install rule creating the `$PREFIX/bin` directory. Because with `./configure --shared` no binary is created, the rule subsequently failed. Fix that by creating the directory before creating the symlinks to the npm and npx scripts. (Whether it makes sense to install npm without a `node` binary is a separate question. This commit is not taking positions. :-)) Regression introduced in commit ed8c89a ("build: fix shared installing target") which, as the commit log indicates, was itself a bug fix for the `./configure --shared` install. PR-URL: #16438 Fixes: #16437 Ref: #15148 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
1 parent 31f54e5 commit 3b64fa4

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

tools/install.py

+1
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ def try_unlink(path):
3333
def try_symlink(source_path, link_path):
3434
print 'symlinking %s -> %s' % (source_path, link_path)
3535
try_unlink(link_path)
36+
try_mkdir_r(os.path.dirname(link_path))
3637
os.symlink(source_path, link_path)
3738

3839
def try_mkdir_r(path):

0 commit comments

Comments
 (0)