Skip to content

Commit 3dcdf27

Browse files
danbevaddaleax
authored andcommitted
test: change ciphers from RC4 to no-such-cipher
This commit updates option ciphers from 'RC4' to 'no-such-cipher' in test/parallel/test-tls-handshake-error.js. The motivation for this change is that this test is verifying that a 'no ciphers match' error be thrown, but 'RC4' might be among the ciphers supported by the OpenSSL version when dynamically linking. I ran into this specific issue when dynamically linking against OpenSSL 1.1.1 on RHEL8 using #25381. PR-URL: #25534 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent d9da4af commit 3dcdf27

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/parallel/test-tls-handshake-error.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ const server = tls.createServer({
1919
assert.throws(() => {
2020
tls.connect({
2121
port: this.address().port,
22-
ciphers: 'RC4'
22+
ciphers: 'no-such-cipher'
2323
}, common.mustNotCall());
2424
}, /no cipher match/i);
2525

0 commit comments

Comments
 (0)