Skip to content

Commit 406b3c0

Browse files
TrottMylesBorins
authored andcommitted
test: use mustNotCall in test-http-eof-on-connect
Confirm that callback is not being invoked in test-http-eof-on-connect.js. PR-URL: #13587 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 135e1e3 commit 406b3c0

File tree

1 file changed

+24
-2
lines changed

1 file changed

+24
-2
lines changed

test/parallel/test-http-eof-on-connect.js

+24-2
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,35 @@
1+
// Copyright Joyent, Inc. and other Node contributors.
2+
//
3+
// Permission is hereby granted, free of charge, to any person obtaining a
4+
// copy of this software and associated documentation files (the
5+
// "Software"), to deal in the Software without restriction, including
6+
// without limitation the rights to use, copy, modify, merge, publish,
7+
// distribute, sublicense, and/or sell copies of the Software, and to permit
8+
// persons to whom the Software is furnished to do so, subject to the
9+
// following conditions:
10+
//
11+
// The above copyright notice and this permission notice shall be included
12+
// in all copies or substantial portions of the Software.
13+
//
14+
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
15+
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
16+
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
17+
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
18+
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
19+
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
20+
// USE OR OTHER DEALINGS IN THE SOFTWARE.
21+
122
'use strict';
2-
require('../common');
23+
24+
const common = require('../common');
325
const net = require('net');
426
const http = require('http');
527

628
// This is a regression test for https://github.com/joyent/node/issues/44
729
// It is separate from test-http-malformed-request.js because it is only
830
// reproduceable on the first packet on the first connection to a server.
931

10-
const server = http.createServer(function(req, res) {});
32+
const server = http.createServer(common.mustNotCall());
1133
server.listen(0);
1234

1335
server.on('listening', function() {

0 commit comments

Comments
 (0)