Skip to content

Commit 40b1f08

Browse files
author
Matheus Marchini
committed
deps: cherry-pick 5dd3395 from upstream V8
Original commit message: [log] improve --perf-basic-prof-only-functions Change --perf-basic-prof-only-functions to also log builtin code creation events, otherwise InterpretedFunctions generated by --interpreted-frames-native-stack will be filtered out. R=yangguo@google.com Change-Id: Ib0623fca88e25c514473a43de56ebbbdcb146f97 Reviewed-on: https://chromium-review.googlesource.com/1100014 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#53760} Refs: v8/v8@5dd3395 PR-URL: #21386 Reviewed-By: Yang Guo <yangguo@chromium.org> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 25e5ae4 commit 40b1f08

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
# Reset this number to 0 on major V8 upgrades.
2929
# Increment by one for each non-official patch applied to deps/v8.
30-
'v8_embedder_string': '-node.8',
30+
'v8_embedder_string': '-node.9',
3131

3232
# Enable disassembler for `--print-code` v8 options
3333
'v8_enable_disassembler': 1,

deps/v8/src/log.cc

+1
Original file line numberDiff line numberDiff line change
@@ -305,6 +305,7 @@ void PerfBasicLogger::LogRecordedBuffer(AbstractCode* code, SharedFunctionInfo*,
305305
const char* name, int length) {
306306
if (FLAG_perf_basic_prof_only_functions &&
307307
(code->kind() != AbstractCode::INTERPRETED_FUNCTION &&
308+
code->kind() != AbstractCode::BUILTIN &&
308309
code->kind() != AbstractCode::OPTIMIZED_FUNCTION)) {
309310
return;
310311
}

0 commit comments

Comments
 (0)