Skip to content

Commit 4686579

Browse files
anonrigRafaelGSS
authored andcommitted
dns: remove unnecessary parameter from validateOneOf
PR-URL: #44635 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
1 parent b209c83 commit 4686579

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

lib/dns.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ function lookup(hostname, options, callback) {
154154
} else if (typeof options === 'number') {
155155
validateFunction(callback, 'callback');
156156

157-
validateOneOf(options, 'family', validFamilies, true);
157+
validateOneOf(options, 'family', validFamilies);
158158
family = options;
159159
} else if (options !== undefined && typeof options !== 'object') {
160160
validateFunction(arguments.length === 2 ? options : callback, 'callback');
@@ -176,7 +176,7 @@ function lookup(hostname, options, callback) {
176176
family = 6;
177177
break;
178178
default:
179-
validateOneOf(options.family, 'options.family', validFamilies, true);
179+
validateOneOf(options.family, 'options.family', validFamilies);
180180
family = options.family;
181181
break;
182182
}

lib/internal/dns/promises.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ function lookup(hostname, options) {
166166
}
167167

168168
if (typeof options === 'number') {
169-
validateOneOf(options, 'family', validFamilies, true);
169+
validateOneOf(options, 'family', validFamilies);
170170
family = options;
171171
} else if (options !== undefined && typeof options !== 'object') {
172172
throw new ERR_INVALID_ARG_TYPE('options', ['integer', 'object'], options);
@@ -177,7 +177,7 @@ function lookup(hostname, options) {
177177
validateHints(hints);
178178
}
179179
if (options?.family != null) {
180-
validateOneOf(options.family, 'options.family', validFamilies, true);
180+
validateOneOf(options.family, 'options.family', validFamilies);
181181
family = options.family;
182182
}
183183
if (options?.all != null) {

0 commit comments

Comments
 (0)