Skip to content

Commit 4963a04

Browse files
committed
vm: move process.binding('contextify') to internalBinding
PR-URL: #22419 Refs: #22160 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 3b5c992 commit 4963a04

File tree

6 files changed

+8
-5
lines changed

6 files changed

+8
-5
lines changed

lib/internal/bootstrap/loaders.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@
107107
};
108108
}
109109

110-
const { ContextifyScript } = process.binding('contextify');
110+
const { ContextifyScript } = internalBinding('contextify');
111111

112112
// Set up NativeModule
113113
function NativeModule(id) {

lib/internal/bootstrap/node.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,8 @@
351351
'v8',
352352
'stream_wrap',
353353
'signal_wrap',
354-
'crypto']);
354+
'crypto',
355+
'contextify']);
355356
process.binding = function binding(name) {
356357
return internalBindingWhitelist.has(name) ?
357358
internalBinding(name) :

lib/internal/vm/source_text_module.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
const { internalBinding } = require('internal/bootstrap/loaders');
44
const { URL } = require('internal/url');
5-
const { isContext } = process.binding('contextify');
5+
const { isContext } = internalBinding('contextify');
66
const {
77
ERR_INVALID_ARG_TYPE,
88
ERR_VM_MODULE_ALREADY_LINKED,

lib/vm.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,12 @@
2121

2222
'use strict';
2323

24+
const { internalBinding } = require('internal/bootstrap/loaders');
2425
const {
2526
ContextifyScript,
2627
makeContext,
2728
isContext: _isContext,
28-
} = process.binding('contextify');
29+
} = internalBinding('contextify');
2930
const { ERR_INVALID_ARG_TYPE } = require('internal/errors').codes;
3031
const { isUint8Array } = require('internal/util/types');
3132
const { validateInt32, validateUint32 } = require('internal/validators');

src/node_contextify.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -958,4 +958,4 @@ void Initialize(Local<Object> target,
958958
} // namespace contextify
959959
} // namespace node
960960

961-
NODE_BUILTIN_MODULE_CONTEXT_AWARE(contextify, node::contextify::Initialize)
961+
NODE_MODULE_CONTEXT_AWARE_INTERNAL(contextify, node::contextify::Initialize)

test/parallel/test-process-binding-internalbinding-whitelist.js

+1
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,4 @@ assert(process.binding('http_parser'));
1111
assert(process.binding('v8'));
1212
assert(process.binding('stream_wrap'));
1313
assert(process.binding('signal_wrap'));
14+
assert(process.binding('contextify'));

0 commit comments

Comments
 (0)