Skip to content

Commit 4ac719f

Browse files
targosrichardlau
authored andcommitted
meta: update label-pr-config
- Rename "ES Modules" label to "esm" (This already happened on GitHub a while ago). - Add missing "fast-track" to deps/npm (It was lost when the pull request adding it landed). - Rename "intl" to "i18n-api" (There is no intl label). - Rename "url-whatwg" to "whatwg-url". - Rename "V8 Engine" to "v8 engine". - Rename "n-api" to "node-api". - Add "python" to .py files. - Add "gyp" to tools/gyp. - Add "icu" to tools/icu. - Add "tools" and "v8 engine" to tools/v8_gypfiles. - Add "release" to doc/changelogs. PR-URL: #38950 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
1 parent 31359e1 commit 4ac719f

File tree

1 file changed

+25
-24
lines changed

1 file changed

+25
-24
lines changed

.github/label-pr-config.yml

+25-24
Original file line numberDiff line numberDiff line change
@@ -11,22 +11,22 @@ subSystemLabels:
1111
/^src\/udp_/: c++, dgram
1212
/^src\/(?:fs_|node_file|node_stat_watcher)/: c++, fs
1313
/^src\/node_http_parser/: c++, http_parser
14-
/^src\/node_i18n/: c++, intl
14+
/^src\/node_i18n/: c++, i18n-api
1515
/^src\/uv\./: c++, libuv
1616
/^src\/(?:connect(?:ion)?|pipe|tcp)_/: c++, net
1717
/^src\/node_os/: c++, os
1818
/^src\/(?:node_main|signal_)/: c++, process
1919
/^src\/timer_/: c++, timers
2020
/^src\/(?:CNNICHashWhitelist|node_root_certs|tls_)/: c++, tls
2121
/^src\/tty_/: c++, tty
22-
/^src\/node_url/: c++, url-whatwg
22+
/^src\/node_url/: c++, whatwg-url
2323
/^src\/node_util/: c++, util
24-
/^src\/(?:node_v8|v8abbr)/: c++, V8 Engine
24+
/^src\/(?:node_v8|v8abbr)/: c++, v8 engine
2525
/^src\/node_contextify/: c++, vm
2626
/^src\/.*win32.*/: c++, windows
2727
/^src\/node_zlib/: c++, zlib
2828
/^src\/tracing/: c++, tracing
29-
/^src\/node_api/: c++, n-api
29+
/^src\/node_api/: c++, node-api
3030
/^src\/node_http2/: c++, http2
3131
/^src\/node_report/: c++, report
3232
/^src\/node_wasi/: c++, wasi
@@ -35,7 +35,7 @@ subSystemLabels:
3535
/^src\/node_bob*/: c++, quic, dont-land-on-v14.x, dont-land-on-v12.x
3636

3737
# don't label python files as c++
38-
/^src\/.+\.py$/: lib / src, needs-ci
38+
/^src\/.+\.py$/: python, needs-ci
3939

4040
# properly label changes to v8 inspector integration-related files
4141
/^src\/inspector_/: c++, inspector, needs-ci
@@ -50,23 +50,24 @@ subSystemLabels:
5050
/^\w+\.md$/: doc
5151
# different variants of *Makefile and build files
5252
/^(tools\/)?(Makefile|BSDmakefile|create_android_makefiles|\.travis\.yml)$/: build, needs-ci
53-
/^tools\/(install\.py|genv8constants\.py|getnodeversion\.py|js2c\.py|utils\.py|configure\.d\/.*)$/: build, needs-ci
53+
/^tools\/(install\.py|genv8constants\.py|getnodeversion\.py|js2c\.py|utils\.py|configure\.d\/.*)$/: build, python, needs-ci
5454
/^vcbuild\.bat$/: build, windows, needs-ci
5555
/^(android-)?configure|node\.gyp|common\.gypi$/: build, needs-ci
5656
# more specific tools
57-
/^tools\/gyp/: tools, build, needs-ci
57+
/^tools\/gyp/: tools, build, gyp, needs-ci
5858
/^tools\/doc\//: tools, doc
59-
/^tools\/icu\//: tools, intl, needs-ci
59+
/^tools\/icu\//: tools, i18n-api, icu, needs-ci
6060
/^tools\/(?:osx-pkg\.pmdoc|pkgsrc)\//: tools, macos, install
6161
/^tools\/(?:(?:mac)?osx-)/: tools, macos
6262
/^tools\/test-npm/: tools, test, npm
6363
/^tools\/test/: tools, test
6464
/^tools\/(?:certdata|mkssldef|mk-ca-bundle)/: tools, openssl, tls
6565
/^tools\/msvs\//: tools, windows, install, needs-ci
6666
/^tools\/[^/]+\.bat$/: tools, windows, needs-ci
67-
/^tools\/make-v8/: tools, V8 Engine, needs-ci
68-
/^tools\/(code_cache|snapshot|v8_gypfiles)/: needs-ci,
69-
/^tools\/build-addons.js/: needs-ci,
67+
/^tools\/make-v8/: tools, v8 engine, needs-ci
68+
/^tools\/v8_gypfiles/: tools, v8 engine, needs-ci
69+
/^tools\/(code_cache|snapshot)/: needs-ci
70+
/^tools\/build-addons.js/: needs-ci
7071
# all other tool changes should be marked as such
7172
/^tools\//: tools
7273
/^\.eslint|\.remark|\.editorconfig/: tools
@@ -75,9 +76,10 @@ subSystemLabels:
7576
# libuv needs an explicit mapping, as the ordinary /deps/ mapping below would
7677
# end up as libuv changes labeled with "uv" (which is a non-existing label)
7778
/^deps\/uv\//: libuv
78-
/^deps\/v8\/tools\/gen-postmortem-metadata\.py/: V8 Engine, post-mortem
79-
/^deps\/v8\//: V8 Engine
79+
/^deps\/v8\/tools\/gen-postmortem-metadata\.py/: v8 engine, python, post-mortem
80+
/^deps\/v8\//: v8 engine
8081
/^deps\/uvwasi\//: wasi
82+
/^deps\/npm\//: npm, fast-track
8183
/^deps\/nghttp2\/nghttp2\.gyp/: build, http2
8284
/^deps\/nghttp2\//: http2
8385
/^deps\/ngtcp2\//: quic, dont-land-on-v14.x, dont-land-on-v12.x
@@ -96,8 +98,8 @@ subSystemLabels:
9698
/^lib\/\w+\/streams$/: stream
9799
/^lib\/.*http2/: http2
98100
/^lib\/worker_threads.js$/: worker
99-
/^lib\/internal\/url\.js$/: url-whatwg
100-
/^lib\/internal\/modules\/esm/: ES Modules
101+
/^lib\/internal\/url\.js$/: whatwg-url
102+
/^lib\/internal\/modules\/esm/: esm
101103
/^lib\/internal\/quic\/*/: quic, dont-land-on-v14.x, dont-land-on-v12.x
102104

103105
# All other lib/ files map directly
@@ -114,24 +116,22 @@ exlusiveLabels:
114116
/^test\/pseudo-tty\//: test, tty
115117
/^test\/inspector\//: test, inspector
116118
/^test\/cctest\/test_inspector/: test, inspector
117-
/^test\/cctest\/test_url/: test, url-whatwg
118-
/^test\/addons-napi\//: test, n-api
119+
/^test\/cctest\/test_url/: test, whatwg-url
120+
/^test\/addons-napi\//: test, node-api
119121
/^test\/async-hooks\//: test, async_hooks
120122
/^test\/report\//: test, report
121-
/^test\/fixtures\/es-module/: test, ES Modules
122-
/^test\/es-module\//: test, ES Modules
123+
/^test\/fixtures\/es-module/: test, esm
124+
/^test\/es-module\//: test, esm
123125

124126
/^test\//: test
125127

126128
# specific map for webcrypto.md as it should be labeled 'crypto'
127129
/^doc\/api\/webcrypto.md$/: doc, crypto
128130
# specific map for modules.md as it should be labeled 'module' not 'modules'
129131
/^doc\/api\/modules.md$/: doc, module
130-
# specific map for esm.md as it should be labeled 'ES Modules' not 'esm'
131-
/^doc\/api\/esm.md$/: doc, ES Modules
132-
# n-api is treated separately since it is not a JS core module but is still
132+
# node-api is treated separately since it is not a JS core module but is still
133133
# considered a subsystem of sorts
134-
/^doc\/api\/n-api.md$/: doc, n-api
134+
/^doc\/api\/n-api.md$/: doc, node-api
135135
# quic
136136
/^doc\/api\/quic.md$/: doc, quic, dont-land-on-v14.x, dont-land-on-v12.x
137137
# add worker label to PRs that affect doc/api/worker_threads.md
@@ -140,12 +140,13 @@ exlusiveLabels:
140140
/^doc\/api\/(\w+)\.md$/: doc, $1
141141
# add deprecations label to PRs that affect doc/api/deprecations.md
142142
/^doc\/api\/deprecations.md$/: doc, deprecations
143+
/^doc\/changelogs\//: release
143144

144145
/^doc\//: doc
145146

146147
# more specific benchmarks
147148
/^benchmark\/buffers\//: benchmark, buffer
148-
/^benchmark\/(?:arrays|es)\//: benchmark, V8 Engine
149+
/^benchmark\/(?:arrays|es)\//: benchmark, v8 engine
149150
/^benchmark\/_http/: benchmark, http
150151
/^benchmark\/(?:misc|fixtures)\//: benchmark
151152
/^benchmark\/streams\//: benchmark, stream

0 commit comments

Comments
 (0)