Skip to content

Commit 4be2e87

Browse files
targosrichardlau
authored andcommitted
deps: V8: cherry-pick 7c182bd65f42
Original commit message: Fix visiblity rules for configs enforced by the latest GN version. Prior versions of GN had a bug (gn:22) where visibility rules for configs weren't being enforced properly. This CL tweaks the visibility settings of some configs to conform to the latest version. Change-Id: Ic5d827a1f2774278d3894f67fe52bfca836c0409 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2360909 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#69463} Refs: v8/v8@7c182bd PR-URL: #39244 Refs: nodejs/build#2696 Reviewed-By: Richard Lau <rlau@redhat.com>
1 parent a83b01a commit 4be2e87

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.69',
39+
'v8_embedder_string': '-node.70',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/BUILD.gn

+8-4
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,8 @@ v8_toolset_for_shell = "host"
308308
#
309309

310310
config("internal_config_base") {
311-
visibility = [ ":*" ] # Only targets in this file can depend on this.
311+
# Only targets in this file and its subdirs can depend on this.
312+
visibility = [ "./*" ]
312313

313314
configs = [ ":v8_tracing_config" ]
314315

@@ -321,7 +322,8 @@ config("internal_config_base") {
321322

322323
config("internal_config") {
323324
defines = []
324-
visibility = [ ":*" ] # Only targets in this file can depend on this.
325+
# Only targets in this file and its subdirs can depend on this.
326+
visibility = [ "./*" ]
325327

326328
configs = [
327329
"//build/config/compiler:wexit_time_destructors",
@@ -429,7 +431,8 @@ config("v8_header_features") {
429431
# Put defines here that are only used in our internal files and NEVER in
430432
# external headers that embedders (such as chromium and node) might include.
431433
config("features") {
432-
visibility = [ ":*" ] # Only targets in this file can depend on this.
434+
# Only targets in this file and its subdirs can depend on this.
435+
visibility = [ "./*" ]
433436

434437
defines = []
435438

@@ -559,7 +562,8 @@ config("features") {
559562
}
560563

561564
config("toolchain") {
562-
visibility = [ ":*" ] # Only targets in this file can depend on this.
565+
# Only targets in this file and its subdirs can depend on this.
566+
visibility = [ "./*" ]
563567

564568
defines = []
565569
cflags = []

deps/v8/third_party/inspector_protocol/BUILD.gn

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import("../../gni/v8.gni")
66

77
config("crdtp_config") {
8-
visibility = [ "../../src/inspector:*" ]
8+
visibility = [ "../../src/inspector:*", ":*" ]
99
configs = [ "../../:internal_config" ]
1010
include_dirs = [ "../../include" ]
1111
}

0 commit comments

Comments
 (0)