@@ -68,17 +68,20 @@ hint: and commit the result with 'git commit'
68
68
using ` git add ` , and then commit the changes. That can be done with
69
69
` git cherry-pick --continue ` .
70
70
6 . Leave the commit message as is. If you think it should be modified, comment
71
- in the Pull Request.
71
+ in the Pull Request. The ` Backport-PR-URL ` metadata does need to be added to
72
+ the commit, but this will be done later.
72
73
7 . Make sure ` make -j4 test ` passes.
73
74
8 . Push the changes to your fork
74
75
9 . Open a pull request:
75
76
1 . Be sure to target the ` v8.x-staging ` branch in the pull request.
76
- 2 . Include the backport target in the pull request title in the following
77
+ 1 . Include the backport target in the pull request title in the following
77
78
format — ` [v8.x backport] <commit title> ` .
78
79
Example: ` [v8.x backport] process: improve performance of nextTick `
79
- 3 . Check the checkbox labeled "Allow edits from maintainers".
80
- 4 . In the description add a reference to the original PR
81
- 5 . Run a [ ` node-test-pull-request ` ] [ ] CI job (with ` REBASE_ONTO ` set to the
80
+ 1 . Check the checkbox labeled "Allow edits from maintainers".
81
+ 1 . In the description add a reference to the original PR.
82
+ 1 . Amend the commit message and include a ` Backport-PR-URL: ` metadata and
83
+ re-push the change to your fork.
84
+ 1 . Run a [ ` node-test-pull-request ` ] [ ] CI job (with ` REBASE_ONTO ` set to the
82
85
default ` <pr base branch> ` )
83
86
10 . If during the review process conflicts arise, use the following to rebase:
84
87
` git pull --rebase upstream v8.x-staging `
0 commit comments