Skip to content

Commit 51ab98c

Browse files
targosnodejs-github-bot
authored andcommitted
deps: silence irrelevant V8 warning
PR-URL: #45579 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 9f84d3e commit 51ab98c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.2',
39+
'v8_embedder_string': '-node.3',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/include/v8-persistent-handle.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ class NonCopyablePersistentTraits {
252252
* This will clone the contents of storage cell, but not any of the flags, etc.
253253
*/
254254
template <class T>
255-
struct V8_DEPRECATED("Use v8::Global instead") CopyablePersistentTraits {
255+
struct CopyablePersistentTraits {
256256
using CopyablePersistent = Persistent<T, CopyablePersistentTraits<T>>;
257257
static const bool kResetInDestructor = true;
258258
template <class S, class M>

0 commit comments

Comments
 (0)