Commit 522fbb0 authored and committed Feb 10, 2025 Verified
1 parent 1486465 commit 522fbb0 Copy full SHA for 522fbb0
File tree 3 files changed +17
-10
lines changed
3 files changed +17
-10
lines changed Original file line number Diff line number Diff line change @@ -456,6 +456,12 @@ make docopen
456
456
This will open a file URL to a one-page version of all the browsable HTML
457
457
documents using the default browser.
458
458
459
+ ``` bash
460
+ make docclean
461
+ ```
462
+
463
+ This will clean previously built doc.
464
+
459
465
To test if Node.js was built correctly:
460
466
461
467
``` bash
Original file line number Diff line number Diff line change 2
2
3
3
{
4
4
function setupTheme ( ) {
5
- const kCustomPreference = 'customDarkTheme' ;
6
- const userSettings = sessionStorage . getItem ( kCustomPreference ) ;
5
+ const storedTheme = localStorage . getItem ( 'theme' ) ;
7
6
const themeToggleButton = document . getElementById ( 'theme-toggle-btn' ) ;
8
7
9
- if ( userSettings === null && window . matchMedia ) {
8
+ // Follow operating system theme preference
9
+ if ( storedTheme === null && window . matchMedia ) {
10
10
const mq = window . matchMedia ( '(prefers-color-scheme: dark)' ) ;
11
11
12
12
if ( 'onchange' in mq ) {
28
28
if ( mq . matches ) {
29
29
document . documentElement . classList . add ( 'dark-mode' ) ;
30
30
}
31
- } else if ( userSettings === 'true ' ) {
31
+ } else if ( storedTheme === 'dark ' ) {
32
32
document . documentElement . classList . add ( 'dark-mode' ) ;
33
33
}
34
34
35
35
if ( themeToggleButton ) {
36
36
themeToggleButton . hidden = false ;
37
37
themeToggleButton . addEventListener ( 'click' , function ( ) {
38
- sessionStorage . setItem (
39
- kCustomPreference ,
40
- document . documentElement . classList . toggle ( 'dark-mode' ) ,
38
+ localStorage . setItem (
39
+ 'theme' ,
40
+ document . documentElement . classList . toggle ( 'dark-mode' ) ? 'dark' : 'light' ,
41
41
) ;
42
42
} ) ;
43
43
}
Original file line number Diff line number Diff line change @@ -532,9 +532,10 @@ The TSC serves as the final arbiter where required.
532
532
[ build] ( https://github.com/nodejs/build/issues ) repositories, open new
533
533
issues. Run a new CI any time someone pushes new code to the pull request.
534
534
4 . Check that the commit message adheres to [ commit message guidelines] [ ] .
535
- 5 . Add all necessary [ metadata] ( #metadata ) to commit messages before landing. If
536
- you are unsure exactly how to format the commit messages, use the commit log
537
- as a reference. See [ this commit] [ commit-example ] as an example.
535
+ 5 . Add all necessary [ metadata] [ git-node-metadata ] to commit messages before
536
+ landing. If you are unsure exactly how to format the commit messages, use
537
+ the commit log as a reference. See [ this commit] [ commit-example ] as an
538
+ example.
538
539
539
540
For pull requests from first-time contributors, be
540
541
[ welcoming] ( #welcoming-first-time-contributors ) . Also, verify that their git
You can’t perform that action at this time.
0 commit comments