Skip to content

Commit 52670fc

Browse files
committed
test: skip whatwg url parse and setter tests when icu is missing
the WHATWG url parser relies on ICU's punycode implementation. A handful of the standard tests fail when ICU is not present because of the additional checks that are not implemented. For now, skip the parse and setter tests if ICU is not present. PR-URL: #9246 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
1 parent d7e4ae1 commit 52670fc

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

test/parallel/test-whatwg-url-parsing.js

+7
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,13 @@
11
'use strict';
22

33
const common = require('../common');
4+
5+
if (!common.hasIntl) {
6+
// A handful of the tests fail when ICU is not included.
7+
common.skip('missing Intl... skipping test');
8+
return;
9+
}
10+
411
const URL = require('url').URL;
512
const path = require('path');
613
const assert = require('assert');

test/parallel/test-whatwg-url-setters.js

+7
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,13 @@
11
'use strict';
22

33
const common = require('../common');
4+
5+
if (!common.hasIntl) {
6+
// A handful of the tests fail when ICU is not included.
7+
common.skip('missing Intl... skipping test');
8+
return;
9+
}
10+
411
const path = require('path');
512
const URL = require('url').URL;
613
const assert = require('assert');

0 commit comments

Comments
 (0)