Skip to content

Commit 52aab47

Browse files
apapirovskiMylesBorins
authored andcommitted
http2: remove unnecessary bind from setImmediate
PR-URL: #28131 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent ad5b715 commit 52aab47

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

lib/internal/http2/core.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -2152,12 +2152,16 @@ class Http2Stream extends Duplex {
21522152
// By using setImmediate we allow pushStreams to make it through
21532153
// before the stream is officially closed. This prevents a bug
21542154
// in most browsers where those pushStreams would be rejected.
2155-
setImmediate(this.close.bind(this));
2155+
setImmediate(callStreamClose, this);
21562156
}
21572157
}
21582158
}
21592159
}
21602160

2161+
function callStreamClose(stream) {
2162+
stream.close();
2163+
}
2164+
21612165
function processHeaders(oldHeaders) {
21622166
assertIsObject(oldHeaders, 'headers');
21632167
const headers = ObjectCreate(null);

0 commit comments

Comments
 (0)