Skip to content

Commit 5331454

Browse files
dayninMylesBorins
authored andcommitted
path: replace "magic" numbers by readable constants
PR-URL: #18654 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
1 parent 92ed071 commit 5331454

File tree

3 files changed

+144
-111
lines changed

3 files changed

+144
-111
lines changed

lib/internal/constants.js

+16
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
'use strict';
2+
3+
module.exports = {
4+
// Alphabet chars.
5+
CHAR_UPPERCASE_A: 65, /*A*/
6+
CHAR_LOWERCASE_A: 97, /*a*/
7+
CHAR_UPPERCASE_Z: 90, /*Z*/
8+
CHAR_LOWERCASE_Z: 122, /*z*/
9+
10+
// Non-alphabetic chars.
11+
CHAR_DOT: 46, /*.*/
12+
CHAR_FORWARD_SLASH: 47, /*/*/
13+
CHAR_BACKWARD_SLASH: 92, /*\*/
14+
CHAR_COLON: 58, /*:*/
15+
CHAR_QUESTION_MARK: 63, /*?*/
16+
};

0 commit comments

Comments
 (0)