Skip to content

Commit 537e5cb

Browse files
yashLadhadanielleadams
authored andcommitted
fs: move method definition from header
We are defining the definition of function in the header file itself. It should be defined in the source file instead of the header file. PR-URL: #36256 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 6bc007f commit 537e5cb

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

src/node_file.cc

+3
Original file line numberDiff line numberDiff line change
@@ -2534,6 +2534,9 @@ void Initialize(Local<Object> target,
25342534
use_promises_symbol).Check();
25352535
}
25362536

2537+
BindingData* FSReqBase::binding_data() {
2538+
return binding_data_.get();
2539+
}
25372540
} // namespace fs
25382541

25392542
} // end namespace node

src/node_file.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ class FSReqBase : public ReqWrap<uv_fs_t> {
109109

110110
void MemoryInfo(MemoryTracker* tracker) const override;
111111

112-
BindingData* binding_data() { return binding_data_.get(); }
112+
BindingData* binding_data();
113113

114114
private:
115115
std::unique_ptr<FSContinuationData> continuation_data_;

0 commit comments

Comments
 (0)