Skip to content

Commit 54d3431

Browse files
thefourtheyegibfahn
authored andcommitted
build: make node-gyp output silent
As it is, node-gyp produces a lot of build related verbose messages. Latest node-gyp upgrade allows us to specify --silent flag to suppress those messages. Except for CI, addons build will run silently. PR-URL: #8990 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
1 parent 6d6f9e5 commit 54d3431

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

Makefile

+5-1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ PREFIX ?= /usr/local
88
FLAKY_TESTS ?= run
99
TEST_CI_ARGS ?=
1010
STAGINGSERVER ?= node-www
11+
LOGLEVEL ?= silent
1112
OSTYPE := $(shell uname -s | tr '[A-Z]' '[a-z]')
1213

1314
ifdef JOBS
@@ -165,7 +166,8 @@ test/addons/.buildstamp: config.gypi \
165166
# Cannot use $(wildcard test/addons/*/) here, it's evaluated before
166167
# embedded addons have been generated from the documentation.
167168
for dirname in test/addons/*/; do \
168-
$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
169+
echo "\nRunning addons test $$PWD/$$dirname" ; \
170+
$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp --loglevel=$(LOGLEVEL) rebuild \
169171
--python="$(PYTHON)" \
170172
--directory="$$PWD/$$dirname" \
171173
--nodedir="$$PWD" || exit 1 ; \
@@ -195,6 +197,7 @@ CI_NATIVE_SUITES := addons
195197
CI_JS_SUITES := doctool inspector known_issues message parallel pseudo-tty sequential
196198

197199
# Build and test addons without building anything else
200+
test-ci-native: LOGLEVEL := info
198201
test-ci-native: | test/addons/.buildstamp
199202
$(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \
200203
--mode=release --flaky-tests=$(FLAKY_TESTS) \
@@ -206,6 +209,7 @@ test-ci-js:
206209
--mode=release --flaky-tests=$(FLAKY_TESTS) \
207210
$(TEST_CI_ARGS) $(CI_JS_SUITES)
208211

212+
test-ci: LOGLEVEL := info
209213
test-ci: | build-addons
210214
out/Release/cctest --gtest_output=tap:cctest.tap
211215
$(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \

0 commit comments

Comments
 (0)