Skip to content

Commit 5562932

Browse files
a0viedojasnell
authored andcommitted
test: fix strictEqual assertion arguments
PR-URL: #23508 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent bb8dd48 commit 5562932

File tree

1 file changed

+52
-52
lines changed

1 file changed

+52
-52
lines changed

test/parallel/test-buffer-alloc.js

+52-52
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const SlowBuffer = require('buffer').SlowBuffer;
77

88

99
const b = Buffer.allocUnsafe(1024);
10-
assert.strictEqual(1024, b.length);
10+
assert.strictEqual(b.length, 1024);
1111

1212
b[0] = -1;
1313
assert.strictEqual(b[0], 255);
@@ -21,17 +21,17 @@ for (let i = 0; i < 1024; i++) {
2121
}
2222

2323
const c = Buffer.allocUnsafe(512);
24-
assert.strictEqual(512, c.length);
24+
assert.strictEqual(c.length, 512);
2525

2626
const d = Buffer.from([]);
27-
assert.strictEqual(0, d.length);
27+
assert.strictEqual(d.length, 0);
2828

2929
// Test offset properties
3030
{
3131
const b = Buffer.alloc(128);
32-
assert.strictEqual(128, b.length);
33-
assert.strictEqual(0, b.byteOffset);
34-
assert.strictEqual(0, b.offset);
32+
assert.strictEqual(b.length, 128);
33+
assert.strictEqual(b.byteOffset, 0);
34+
assert.strictEqual(b.offset, 0);
3535
}
3636

3737
// Test creating a Buffer from a Uint32Array
@@ -176,7 +176,7 @@ Buffer.alloc(1).write('', 1, 0);
176176

177177
{
178178
const slice = b.slice(100, 150);
179-
assert.strictEqual(50, slice.length);
179+
assert.strictEqual(slice.length, 50);
180180
for (let i = 0; i < 50; i++) {
181181
assert.strictEqual(b[100 + i], slice[i]);
182182
}
@@ -213,13 +213,13 @@ Buffer.alloc(1).write('', 1, 0);
213213
const a = Buffer.allocUnsafe(8);
214214
for (let i = 0; i < 8; i++) a[i] = i;
215215
const b = a.slice(4, 8);
216-
assert.strictEqual(4, b[0]);
217-
assert.strictEqual(5, b[1]);
218-
assert.strictEqual(6, b[2]);
219-
assert.strictEqual(7, b[3]);
216+
assert.strictEqual(b[0], 4);
217+
assert.strictEqual(b[1], 5);
218+
assert.strictEqual(b[2], 6);
219+
assert.strictEqual(b[3], 7);
220220
const c = b.slice(2, 4);
221-
assert.strictEqual(6, c[0]);
222-
assert.strictEqual(7, c[1]);
221+
assert.strictEqual(c[0], 6);
222+
assert.strictEqual(c[1], 7);
223223
}
224224

225225
{
@@ -287,7 +287,7 @@ Buffer.alloc(1).write('', 1, 0);
287287
//
288288
// Test toString('base64')
289289
//
290-
assert.strictEqual('TWFu', (Buffer.from('Man')).toString('base64'));
290+
assert.strictEqual((Buffer.from('Man')).toString('base64'), 'TWFu');
291291

292292
{
293293
// test that regular and URL-safe base64 both work
@@ -487,7 +487,7 @@ assert.deepStrictEqual(Buffer.from(' YWJvcnVtLg', 'base64'),
487487
const b = Buffer.from(s);
488488

489489
for (let i = 0; i < l; i++) {
490-
assert.strictEqual('h'.charCodeAt(0), b[i]);
490+
assert.strictEqual(b[i], 'h'.charCodeAt(0));
491491
}
492492

493493
const sb = b.toString();
@@ -557,16 +557,16 @@ function buildBuffer(data) {
557557

558558
const x = buildBuffer([0x81, 0xa3, 0x66, 0x6f, 0x6f, 0xa3, 0x62, 0x61, 0x72]);
559559

560-
assert.strictEqual('<Buffer 81 a3 66 6f 6f a3 62 61 72>', x.inspect());
560+
assert.strictEqual(x.inspect(), '<Buffer 81 a3 66 6f 6f a3 62 61 72>');
561561

562562
{
563563
const z = x.slice(4);
564-
assert.strictEqual(5, z.length);
565-
assert.strictEqual(0x6f, z[0]);
566-
assert.strictEqual(0xa3, z[1]);
567-
assert.strictEqual(0x62, z[2]);
568-
assert.strictEqual(0x61, z[3]);
569-
assert.strictEqual(0x72, z[4]);
564+
assert.strictEqual(z.length, 5);
565+
assert.strictEqual(z[0], 0x6f);
566+
assert.strictEqual(z[1], 0xa3);
567+
assert.strictEqual(z[2], 0x62);
568+
assert.strictEqual(z[3], 0x61);
569+
assert.strictEqual(z[4], 0x72);
570570
}
571571

572572
{
@@ -576,27 +576,27 @@ assert.strictEqual('<Buffer 81 a3 66 6f 6f a3 62 61 72>', x.inspect());
576576

577577
{
578578
const z = x.slice(0, 4);
579-
assert.strictEqual(4, z.length);
580-
assert.strictEqual(0x81, z[0]);
581-
assert.strictEqual(0xa3, z[1]);
579+
assert.strictEqual(z.length, 4);
580+
assert.strictEqual(z[0], 0x81);
581+
assert.strictEqual(z[1], 0xa3);
582582
}
583583

584584
{
585585
const z = x.slice(0, 9);
586-
assert.strictEqual(9, z.length);
586+
assert.strictEqual(z.length, 9);
587587
}
588588

589589
{
590590
const z = x.slice(1, 4);
591-
assert.strictEqual(3, z.length);
592-
assert.strictEqual(0xa3, z[0]);
591+
assert.strictEqual(z.length, 3);
592+
assert.strictEqual(z[0], 0xa3);
593593
}
594594

595595
{
596596
const z = x.slice(2, 4);
597-
assert.strictEqual(2, z.length);
598-
assert.strictEqual(0x66, z[0]);
599-
assert.strictEqual(0x6f, z[1]);
597+
assert.strictEqual(z.length, 2);
598+
assert.strictEqual(z[0], 0x66);
599+
assert.strictEqual(z[1], 0x6f);
600600
}
601601

602602
['ucs2', 'ucs-2', 'utf16le', 'utf-16le'].forEach((encoding) => {
@@ -616,33 +616,33 @@ assert.strictEqual('<Buffer 81 a3 66 6f 6f a3 62 61 72>', x.inspect());
616616
const b = Buffer.from([0xde, 0xad, 0xbe, 0xef]);
617617
let s = String.fromCharCode(0xffff);
618618
b.write(s, 0, 'latin1');
619-
assert.strictEqual(0xff, b[0]);
620-
assert.strictEqual(0xad, b[1]);
621-
assert.strictEqual(0xbe, b[2]);
622-
assert.strictEqual(0xef, b[3]);
619+
assert.strictEqual(b[0], 0xff);
620+
assert.strictEqual(b[1], 0xad);
621+
assert.strictEqual(b[2], 0xbe);
622+
assert.strictEqual(b[3], 0xef);
623623
s = String.fromCharCode(0xaaee);
624624
b.write(s, 0, 'latin1');
625-
assert.strictEqual(0xee, b[0]);
626-
assert.strictEqual(0xad, b[1]);
627-
assert.strictEqual(0xbe, b[2]);
628-
assert.strictEqual(0xef, b[3]);
625+
assert.strictEqual(b[0], 0xee);
626+
assert.strictEqual(b[1], 0xad);
627+
assert.strictEqual(b[2], 0xbe);
628+
assert.strictEqual(b[3], 0xef);
629629
}
630630

631631
{
632632
// Binary encoding should write only one byte per character.
633633
const b = Buffer.from([0xde, 0xad, 0xbe, 0xef]);
634634
let s = String.fromCharCode(0xffff);
635635
b.write(s, 0, 'latin1');
636-
assert.strictEqual(0xff, b[0]);
637-
assert.strictEqual(0xad, b[1]);
638-
assert.strictEqual(0xbe, b[2]);
639-
assert.strictEqual(0xef, b[3]);
636+
assert.strictEqual(b[0], 0xff);
637+
assert.strictEqual(b[1], 0xad);
638+
assert.strictEqual(b[2], 0xbe);
639+
assert.strictEqual(b[3], 0xef);
640640
s = String.fromCharCode(0xaaee);
641641
b.write(s, 0, 'latin1');
642-
assert.strictEqual(0xee, b[0]);
643-
assert.strictEqual(0xad, b[1]);
644-
assert.strictEqual(0xbe, b[2]);
645-
assert.strictEqual(0xef, b[3]);
642+
assert.strictEqual(b[0], 0xee);
643+
assert.strictEqual(b[1], 0xad);
644+
assert.strictEqual(b[2], 0xbe);
645+
assert.strictEqual(b[3], 0xef);
646646
}
647647

648648
{
@@ -715,11 +715,11 @@ assert.strictEqual('<Buffer 81 a3 66 6f 6f a3 62 61 72>', x.inspect());
715715
{
716716
// test offset returns are correct
717717
const b = Buffer.allocUnsafe(16);
718-
assert.strictEqual(4, b.writeUInt32LE(0, 0));
719-
assert.strictEqual(6, b.writeUInt16LE(0, 4));
720-
assert.strictEqual(7, b.writeUInt8(0, 6));
721-
assert.strictEqual(8, b.writeInt8(0, 7));
722-
assert.strictEqual(16, b.writeDoubleLE(0, 8));
718+
assert.strictEqual(b.writeUInt32LE(0, 0), 4);
719+
assert.strictEqual(b.writeUInt16LE(0, 4), 6);
720+
assert.strictEqual(b.writeUInt8(0, 6), 7);
721+
assert.strictEqual(b.writeInt8(0, 7), 8);
722+
assert.strictEqual(b.writeDoubleLE(0, 8), 16);
723723
}
724724

725725
{

0 commit comments

Comments
 (0)