Skip to content

Commit 56299f7

Browse files
benjamingrmarco-ippolito
authored andcommitted
stream: improve inspector ergonomics
PR-URL: #53800 Fixes: #53789 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
1 parent 2f66c7e commit 56299f7

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

lib/internal/webstreams/readablestream.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -2034,8 +2034,8 @@ function readableStreamError(stream, error) {
20342034
assert(stream[kState].state === 'readable');
20352035
stream[kState].state = 'errored';
20362036
stream[kState].storedError = error;
2037-
stream[kIsClosedPromise].reject(error);
20382037
setPromiseHandled(stream[kIsClosedPromise].promise);
2038+
stream[kIsClosedPromise].reject(error);
20392039

20402040
const {
20412041
reader,
@@ -2044,8 +2044,8 @@ function readableStreamError(stream, error) {
20442044
if (reader === undefined)
20452045
return;
20462046

2047-
reader[kState].close.reject(error);
20482047
setPromiseHandled(reader[kState].close.promise);
2048+
reader[kState].close.reject(error);
20492049

20502050
if (readableStreamHasDefaultReader(stream)) {
20512051
for (let n = 0; n < reader[kState].readRequests.length; n++)

lib/internal/webstreams/writablestream.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -761,15 +761,15 @@ function writableStreamRejectCloseAndClosedPromiseIfNeeded(stream) {
761761
};
762762
}
763763

764-
stream[kIsClosedPromise].reject(stream[kState]?.storedError);
765764
setPromiseHandled(stream[kIsClosedPromise].promise);
765+
stream[kIsClosedPromise].reject(stream[kState]?.storedError);
766766

767767
const {
768768
writer,
769769
} = stream[kState];
770770
if (writer !== undefined) {
771-
writer[kState].close.reject?.(stream[kState].storedError);
772771
setPromiseHandled(writer[kState].close.promise);
772+
writer[kState].close.reject?.(stream[kState].storedError);
773773
}
774774
}
775775

0 commit comments

Comments
 (0)