http2: destroy() stream, upon errnoException

SirR4T · MylesBorins · commit 58a7fd0720d2 · 2018-05-15T12:17:53.000-04:00
First steps towards #19060 Backport-PR-URL: #20456 PR-URL: #19389 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
@@ -1647,7 +1647,7 @@ class Http2Stream extends Duplex {
     req.async = false;
     const err = createWriteReq(req, handle, data, encoding);
     if (err)
-      throw util._errnoException(err, 'write', req.error);
+      return this.destroy(util._errnoException(err, 'write', req.error), cb);
     trackWriteState(this, req.bytes);
   }
 
@@ -1690,7 +1690,7 @@ class Http2Stream extends Duplex {
     }
     const err = handle.writev(req, chunks);
     if (err)
-      throw util._errnoException(err, 'write', req.error);
+      return this.destroy(util._errnoException(err, 'write', req.error), cb);
     trackWriteState(this, req.bytes);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -1647,7 +1647,7 @@ class Http2Stream extends Duplex {`
`1647`	`1647`	`req.async = false;`
`1648`	`1648`	`const err = createWriteReq(req, handle, data, encoding);`
`1649`	`1649`	`if (err)`
`1650`		`- throw util._errnoException(err, 'write', req.error);`
	`1650`	`+ return this.destroy(util._errnoException(err, 'write', req.error), cb);`
`1651`	`1651`	`trackWriteState(this, req.bytes);`
`1652`	`1652`	`}`
`1653`	`1653`
`@@ -1690,7 +1690,7 @@ class Http2Stream extends Duplex {`
`1690`	`1690`	`}`
`1691`	`1691`	`const err = handle.writev(req, chunks);`
`1692`	`1692`	`if (err)`
`1693`		`- throw util._errnoException(err, 'write', req.error);`
	`1693`	`+ return this.destroy(util._errnoException(err, 'write', req.error), cb);`
`1694`	`1694`	`trackWriteState(this, req.bytes);`
`1695`	`1695`	`}`
`1696`	`1696`