Skip to content

Commit 5905b14

Browse files
Stewart AddisonFishrock123
Stewart Addison
authored andcommitted
build: fix icutrim when building small-icu on BE
Fix a build error that occurs when icutrim is run to cut down the ICU locale set on Big-Endian platforms when building with --with-intl=small-icu (which is done by the "make binary" target). This fixes the binary build on POWER platforms. Fixes: #2601 PR-URL: #2602 Reviewed-By: Steven Loomis <srloomis@us.ibm.com>
1 parent 71b5d80 commit 5905b14

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

tools/icu/icu-generic.gyp

+10-2
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,17 @@
2929
'type': 'none',
3030
'toolsets': [ 'host', 'target' ],
3131
'direct_dependent_settings': {
32+
'conditions': [
33+
[ 'icu_endianness == "l"', {
34+
'defines': [
35+
# ICU cannot swap the initial data without this.
36+
# http://bugs.icu-project.org/trac/ticket/11046
37+
'UCONFIG_NO_LEGACY_CONVERSION=1',
38+
'UCONFIG_NO_IDNA=1',
39+
],
40+
}],
41+
],
3242
'defines': [
33-
'UCONFIG_NO_LEGACY_CONVERSION=1',
34-
'UCONFIG_NO_IDNA=1',
3543
'UCONFIG_NO_TRANSLITERATION=1',
3644
'UCONFIG_NO_SERVICE=1',
3745
'UCONFIG_NO_REGULAR_EXPRESSIONS=1',

0 commit comments

Comments
 (0)