Skip to content

Commit 59e6f62

Browse files
committed
deps: disable V8 concurrent sparkplug compilation
It introduces process hangs on some platforms because Node.js doesn't tear down V8 correctly. Disable it while we work on a solution. Refs: #47297 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902 PR-URL: #47450 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #51362 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
1 parent 0423f7e commit 59e6f62

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737

3838
# Reset this number to 0 on major V8 upgrades.
3939
# Increment by one for each non-official patch applied to deps/v8.
40-
'v8_embedder_string': '-node.2',
40+
'v8_embedder_string': '-node.3',
4141

4242
##### V8 defaults for Node.js #####
4343

deps/v8/src/flags/flag-definitions.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -936,7 +936,7 @@ DEFINE_BOOL(baseline_batch_compilation, true, "batch compile Sparkplug code")
936936
DEFINE_BOOL_READONLY(concurrent_sparkplug, false,
937937
"compile Sparkplug code in a background thread")
938938
#else
939-
DEFINE_BOOL(concurrent_sparkplug, ENABLE_SPARKPLUG_BY_DEFAULT,
939+
DEFINE_BOOL(concurrent_sparkplug, false,
940940
"compile Sparkplug code in a background thread")
941941
DEFINE_WEAK_IMPLICATION(future, concurrent_sparkplug)
942942
DEFINE_NEG_IMPLICATION(predictable, concurrent_sparkplug)

0 commit comments

Comments
 (0)