Skip to content

Commit 5a0332e

Browse files
Trottaddaleax
authored andcommitted
test: remove potential race condition in https renegotiation test
In test/pummel/test-https-ci-reneg-attack.js, there is a boolean that is causing a race condition on some operating systems. It is unnecessary. Remove it. PR-URL: #25601 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 34da9a3 commit 5a0332e

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

test/pummel/test-https-ci-reneg-attack.js

-4
Original file line numberDiff line numberDiff line change
@@ -52,15 +52,12 @@ function test(next) {
5252
key: fixtures.readSync('test_key.pem')
5353
};
5454

55-
let seenError = false;
56-
5755
const server = https.createServer(options, function(req, res) {
5856
const conn = req.connection;
5957
conn.on('error', function(err) {
6058
console.error(`Caught exception: ${err}`);
6159
assert(/TLS session renegotiation attack/.test(err));
6260
conn.destroy();
63-
seenError = true;
6461
});
6562
res.end('ok');
6663
});
@@ -78,7 +75,6 @@ function test(next) {
7875
let renegs = 0;
7976

8077
child.stderr.on('data', function(data) {
81-
if (seenError) return;
8278
handshakes += ((String(data)).match(/verify return:1/g) || []).length;
8379
if (handshakes === 2) spam();
8480
renegs += ((String(data)).match(/RENEGOTIATING/g) || []).length;

0 commit comments

Comments
 (0)