Skip to content

Commit 5a5bc58

Browse files
peterwmwongaddaleax
authored andcommitted
test: remove unused --expose-native-as V8 flag
test-preload.js was using a V8 flag (`--expose-native-as`) that made an V8 internally used object available. As this test does not use this object, this commit removes the usage of this flag. In some distant past, this internally used object may have had some external use, but currently is essentially an empty object. In the near future, the V8 internal infrastructure (JS Natives) producing the object exposed by `--expose-native-as` will be phased out. For more details, visit: https://bugs.chromium.org/p/v8/issues/detail?id=7624 PR-URL: #25275 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
1 parent 61fc3bf commit 5a5bc58

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/parallel/test-preload.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ if (common.isWindows) {
155155
// https://github.com/nodejs/node/issues/1691
156156
process.chdir(fixtures.fixturesDir);
157157
childProcess.exec(
158-
`"${nodeBinary}" --expose_natives_as=v8natives --require ` +
158+
`"${nodeBinary}" --require ` +
159159
`"${fixtures.path('cluster-preload.js')}" cluster-preload-test.js`,
160160
function(err, stdout, stderr) {
161161
assert.ifError(err);

0 commit comments

Comments
 (0)