Skip to content

Commit 5b6f280

Browse files
committed
Split forbidden host/domain code points, and add all C0 controls and add U+007F to the latter
1 parent 644b1c5 commit 5b6f280

File tree

1 file changed

+13
-6
lines changed

1 file changed

+13
-6
lines changed

src/node_url.cc

+13-6
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,9 @@ enum url_cb_args {
165165
// https://infra.spec.whatwg.org/#ascii-tab-or-newline
166166
CHAR_TEST(8, IsASCIITabOrNewline, (ch == '\t' || ch == '\n' || ch == '\r'))
167167

168+
// https://infra.spec.whatwg.org/#c0-control
169+
CHAR_TEST(8, IsC0Control, (ch >= '\0' && ch <= '\x1f'))
170+
168171
// https://infra.spec.whatwg.org/#c0-control-or-space
169172
CHAR_TEST(8, IsC0ControlOrSpace, (ch >= '\0' && ch <= ' '))
170173

@@ -192,10 +195,14 @@ T ASCIILowercase(T ch) {
192195
// https://url.spec.whatwg.org/#forbidden-host-code-point
193196
CHAR_TEST(8, IsForbiddenHostCodePoint,
194197
ch == '\0' || ch == '\t' || ch == '\n' || ch == '\r' ||
195-
ch == ' ' || ch == '#' || ch == '%' || ch == '/' ||
196-
ch == ':' || ch == '?' || ch == '@' || ch == '[' ||
197-
ch == '<' || ch == '>' || ch == '\\' || ch == ']' ||
198-
ch == '^' || ch == '|')
198+
ch == ' ' || ch == '#' || ch == '/' || ch == ':' ||
199+
ch == '?' || ch == '@' || ch == '[' || ch == '<' ||
200+
ch == '>' || ch == '\\' || ch == ']' || ch == '^' ||
201+
ch == '|')
202+
203+
// https://url.spec.whatwg.org/#forbidden-domain-code-point
204+
CHAR_TEST(8, IsForbiddenDomainCodePoint,
205+
(IsForbiddenHostCodePoint(ch) || IsC0Control(ch) || ch == '%' || ch == '\x7f'))
199206

200207
// https://url.spec.whatwg.org/#windows-drive-letter
201208
TWO_CHAR_STRING_TEST(8, IsWindowsDriveLetter,
@@ -457,7 +464,7 @@ void URLHost::ParseOpaqueHost(const char* input, size_t length) {
457464
output.reserve(length);
458465
for (size_t i = 0; i < length; i++) {
459466
const char ch = input[i];
460-
if (ch != '%' && IsForbiddenHostCodePoint(ch)) {
467+
if (IsForbiddenHostCodePoint(ch)) {
461468
return;
462469
} else {
463470
AppendOrEscape(&output, ch, C0_CONTROL_ENCODE_SET);
@@ -496,7 +503,7 @@ void URLHost::ParseHost(const char* input,
496503
// If any of the following characters are still present, we have to fail
497504
for (size_t n = 0; n < decoded.size(); n++) {
498505
const char ch = decoded[n];
499-
if (IsForbiddenHostCodePoint(ch)) {
506+
if (IsForbiddenDomainCodePoint(ch)) {
500507
return;
501508
}
502509
}

0 commit comments

Comments
 (0)