Skip to content

Commit 5c4f569

Browse files
Trottrvagg
authored andcommittedNov 28, 2018
doc: simplify first-time contributors section of Collaborator Guide
PR-URL: #24387 Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
1 parent 7c29e9b commit 5c4f569

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed
 

‎COLLABORATOR_GUIDE.md

+6-8
Original file line numberDiff line numberDiff line change
@@ -50,16 +50,14 @@ request. See [Who to CC in the issue tracker](#who-to-cc-in-the-issue-tracker).
5050

5151
### Welcoming First-Time Contributors
5252

53-
Courtesy should always be shown to individuals submitting issues and pull
54-
requests to the Node.js project. Be welcoming to first-time contributors,
55-
identified by the GitHub ![First-time contributor](./doc/first_timer_badge.png)
56-
badge.
53+
Always show courtesy to individuals submitting issues and pull requests. Be
54+
welcoming to first-time contributors, identified by the GitHub
55+
![First-time contributor](./doc/first_timer_badge.png) badge.
5756

58-
For first-time contributors, check if the commit author is the same as the
59-
pull request author, and ask if they have configured their git
57+
For first-time contributors, check if the commit author is the same as the pull
58+
request author. This way, once their pull request lands, GitHub will show them
59+
as a _Contributor_. Ask if they have configured their git
6060
[username][git-username] and [email][git-email] to their liking.
61-
This is to make sure they would be promoted to "contributor" once their
62-
pull request lands.
6361

6462
### Closing Issues and Pull Requests
6563

0 commit comments

Comments
 (0)