Skip to content

Commit 5cddd3b

Browse files
committed
src: update NODE_MODULE_VERSION to 124
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 12.2. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: #51362 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
1 parent 94f0369 commit 5cddd3b

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

doc/abi_version_registry.json

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"NODE_MODULE_VERSION": [
3+
{ "modules": 124,"runtime": "node", "variant": "v8_12.2", "versions": "22.0.0-pre" },
34
{ "modules": 123,"runtime": "electron", "variant": "electron", "versions": "30" },
45
{ "modules": 122,"runtime": "node", "variant": "v8_11.9", "versions": "22.0.0-pre" },
56
{ "modules": 121,"runtime": "electron", "variant": "electron", "versions": "29" },

src/node_version.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@
9595
#if defined(NODE_EMBEDDER_MODULE_VERSION)
9696
#define NODE_MODULE_VERSION NODE_EMBEDDER_MODULE_VERSION
9797
#else
98-
#define NODE_MODULE_VERSION 122
98+
#define NODE_MODULE_VERSION 124
9999
#endif
100100

101101
// The NAPI_VERSION supported by the runtime. This is the inclusive range of

0 commit comments

Comments
 (0)