Skip to content

Commit 5f8950b

Browse files
kjinBethGriggs
authored andcommitted
src: emit 'params' instead of 'data' for NodeTracing.dataCollected
PR-URL: #24949 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent d0270f3 commit 5f8950b

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/inspector/tracing_agent.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class InspectorTraceWriter : public node::tracing::AsyncTraceWriter {
3131
return;
3232
json_writer_.reset();
3333
std::ostringstream result(
34-
"{\"method\":\"NodeTracing.dataCollected\",\"data\":",
34+
"{\"method\":\"NodeTracing.dataCollected\",\"params\":",
3535
std::ostringstream::ate);
3636
result << stream_.str();
3737
result << "}";

test/parallel/test-inspector-tracing-domain.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ async function test() {
6060
await generateTrace();
6161
JSON.stringify(await post('NodeTracing.stop', { traceConfig }));
6262
session.disconnect();
63-
assert(traceNotification.data.value.length > 0);
63+
assert(traceNotification.params.value.length > 0);
6464
assert(tracingComplete);
6565
clearInterval(interval);
6666
console.log('Success');

test/parallel/test-trace-events-dynamic-enable.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ async function test() {
2828
const events = [];
2929
let tracingComplete = false;
3030
session.on('NodeTracing.dataCollected', (n) => {
31-
assert.ok(n && n.data && n.data.value);
32-
events.push(...n.data.value); // append the events.
31+
assert.ok(n && n.params && n.params.value);
32+
events.push(...n.params.value); // append the events.
3333
});
3434
session.on('NodeTracing.tracingComplete', () => tracingComplete = true);
3535

0 commit comments

Comments
 (0)