Skip to content

Commit 61eec0c

Browse files
committed
test: wait for message from parent in embedding cctest
I’ve seen this fail a few times in CI, presumably because the inspector commmand did not reach the child thread in time. Explicitly waiting seems to solve that. Refs: #30467 Backport-PR-URL: #35241 PR-URL: #32563 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent cb635c2 commit 61eec0c

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

test/cctest/test_environment.cc

+1
Original file line numberDiff line numberDiff line change
@@ -406,6 +406,7 @@ TEST_F(EnvironmentTest, InspectorMultipleEmbeddedEnvironments) {
406406

407407
v8::Local<v8::Value> extracted_value = LoadEnvironment(
408408
environment,
409+
"while (!global.variableFromParent) {}\n"
409410
"return global.variableFromParent;",
410411
std::move(data->inspector_parent_handle)).ToLocalChecked();
411412

0 commit comments

Comments
 (0)