Skip to content

Commit 62b8640

Browse files
hidaviddongtargos
authored andcommitted
test: refactor test-whatwg-webstreams-encoding to be shorter
PR-URL: #54569 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
1 parent 4fb2c3b commit 62b8640

File tree

1 file changed

+18
-42
lines changed

1 file changed

+18
-42
lines changed

test/parallel/test-whatwg-webstreams-encoding.js

+18-42
Original file line numberDiff line numberDiff line change
@@ -45,32 +45,15 @@ const kEuro = Buffer.from([0xe2, 0x82, 0xac]).toString();
4545
assert.strictEqual(tds.encoding, 'utf-8');
4646
assert.strictEqual(tds.fatal, false);
4747
assert.strictEqual(tds.ignoreBOM, false);
48-
49-
assert.throws(
50-
() => Reflect.get(TextDecoderStream.prototype, 'encoding', {}), {
51-
name: 'TypeError',
52-
message: /Cannot read private member/,
53-
});
54-
assert.throws(
55-
() => Reflect.get(TextDecoderStream.prototype, 'fatal', {}), {
56-
name: 'TypeError',
57-
message: /Cannot read private member/,
58-
});
59-
assert.throws(
60-
() => Reflect.get(TextDecoderStream.prototype, 'ignoreBOM', {}), {
61-
name: 'TypeError',
62-
message: /Cannot read private member/,
63-
});
64-
assert.throws(
65-
() => Reflect.get(TextDecoderStream.prototype, 'readable', {}), {
66-
name: 'TypeError',
67-
message: /Cannot read private member/,
68-
});
69-
assert.throws(
70-
() => Reflect.get(TextDecoderStream.prototype, 'writable', {}), {
71-
name: 'TypeError',
72-
message: /Cannot read private member/,
73-
});
48+
['encoding', 'fatal', 'ignoreBOM', 'readable', 'writable'].forEach((getter) => {
49+
assert.throws(
50+
() => Reflect.get(TextDecoderStream.prototype, getter, {}), {
51+
name: 'TypeError',
52+
message: /Cannot read private member/,
53+
stack: new RegExp(`at get ${getter}`)
54+
}
55+
);
56+
});
7457
}
7558

7659
{
@@ -91,20 +74,13 @@ const kEuro = Buffer.from([0xe2, 0x82, 0xac]).toString();
9174
]).then(common.mustCall());
9275

9376
assert.strictEqual(tds.encoding, 'utf-8');
94-
95-
assert.throws(
96-
() => Reflect.get(TextEncoderStream.prototype, 'encoding', {}), {
97-
name: 'TypeError',
98-
message: /Cannot read private member/,
99-
});
100-
assert.throws(
101-
() => Reflect.get(TextEncoderStream.prototype, 'readable', {}), {
102-
name: 'TypeError',
103-
message: /Cannot read private member/,
104-
});
105-
assert.throws(
106-
() => Reflect.get(TextEncoderStream.prototype, 'writable', {}), {
107-
name: 'TypeError',
108-
message: /Cannot read private member/,
109-
});
77+
['encoding', 'readable', 'writable'].forEach((getter) => {
78+
assert.throws(
79+
() => Reflect.get(TextDecoderStream.prototype, getter, {}), {
80+
name: 'TypeError',
81+
message: /Cannot read private member/,
82+
stack: new RegExp(`at get ${getter}`)
83+
}
84+
);
85+
});
11086
}

0 commit comments

Comments
 (0)