Skip to content

Commit 62ef1eb

Browse files
fossamagnaruyadorno
authored andcommitted
build: add --v8-disable-object-print flag
--v8-enable-object-print flag is set by default true. so, no way of disable this flag. add a --v8-disable-object-print flag instead that defaults to false. Fixes: #45433 PR-URL: #45458 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
1 parent 628891d commit 62ef1eb

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

configure.py

+12-2
Original file line numberDiff line numberDiff line change
@@ -776,7 +776,13 @@
776776
action='store_true',
777777
dest='v8_enable_object_print',
778778
default=True,
779-
help='compile V8 with auxiliar functions for native debuggers')
779+
help='compile V8 with auxiliary functions for native debuggers')
780+
781+
parser.add_argument('--v8-disable-object-print',
782+
action='store_true',
783+
dest='v8_disable_object_print',
784+
default=False,
785+
help='disable the V8 auxiliary functions for native debuggers')
780786

781787
parser.add_argument('--v8-enable-hugepage',
782788
action='store_true',
@@ -1437,7 +1443,7 @@ def configure_v8(o):
14371443
o['variables']['v8_no_strict_aliasing'] = 1 # Work around compiler bugs.
14381444
o['variables']['v8_optimized_debug'] = 0 if options.v8_non_optimized_debug else 1
14391445
o['variables']['dcheck_always_on'] = 1 if options.v8_with_dchecks else 0
1440-
o['variables']['v8_enable_object_print'] = 1 if options.v8_enable_object_print else 0
1446+
o['variables']['v8_enable_object_print'] = 0 if options.v8_disable_object_print else 1
14411447
o['variables']['v8_random_seed'] = 0 # Use a random seed for hash tables.
14421448
o['variables']['v8_promise_internal_field_count'] = 1 # Add internal field to promises for async hooks.
14431449
o['variables']['v8_use_siphash'] = 0 if options.without_siphash else 1
@@ -1460,6 +1466,10 @@ def configure_v8(o):
14601466
o['variables']['v8_enable_hugepage'] = 1 if options.v8_enable_hugepage else 0
14611467
if options.v8_enable_short_builtin_calls or o['variables']['target_arch'] == 'x64':
14621468
o['variables']['v8_enable_short_builtin_calls'] = 1
1469+
if options.v8_enable_object_print and options.v8_disable_object_print:
1470+
raise Exception(
1471+
'Only one of the --v8-enable-object-print or --v8-disable-object-print options '
1472+
'can be specified at a time.')
14631473

14641474
def configure_openssl(o):
14651475
variables = o['variables']

0 commit comments

Comments
 (0)