Skip to content

Commit 62f5a0b

Browse files
bnoordhuisaddaleax
authored andcommittedDec 8, 2016
test: check result of uv_loop_init and uv_write
Silence coverity warnings about the return value not being checked. PR-URL: #10126 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 19432f0 commit 62f5a0b

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed
 

‎test/cctest/test_inspector_socket.cc

+4-3
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,9 @@ static void do_write(const char* data, int len) {
121121
uv_buf_t buf[1];
122122
buf[0].base = const_cast<char*>(data);
123123
buf[0].len = len;
124-
uv_write(&req, reinterpret_cast<uv_stream_t*>(&client_socket), buf, 1,
125-
write_done);
124+
GTEST_ASSERT_EQ(0,
125+
uv_write(&req, reinterpret_cast<uv_stream_t*>(&client_socket),
126+
buf, 1, write_done));
126127
SPIN_WHILE(req.data);
127128
}
128129

@@ -360,7 +361,7 @@ class InspectorSocketTest : public ::testing::Test {
360361
connected = false;
361362
inspector_ready = false;
362363
last_event = kInspectorHandshakeHttpGet;
363-
uv_loop_init(&loop);
364+
GTEST_ASSERT_EQ(0, uv_loop_init(&loop));
364365
server = uv_tcp_t();
365366
client_socket = uv_tcp_t();
366367
server.data = &inspector;

0 commit comments

Comments
 (0)
Please sign in to comment.