Skip to content

Commit 63e33ac

Browse files
danbevgibfahn
authored andcommitted
build: make doc target quiet
Currently it can be a little difficult to detect errors in the output from the doc target. This commit suggests reducing the output to make it easier to identify errors. PR-URL: #16516 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
1 parent 95a61cb commit 63e33ac

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

Makefile

+5-5
Original file line numberDiff line numberDiff line change
@@ -542,13 +542,13 @@ doc-only: $(apidocs_html) $(apidocs_json)
542542
doc: $(NODE_EXE) doc-only
543543

544544
$(apidoc_dirs):
545-
mkdir -p $@
545+
@mkdir -p $@
546546

547547
out/doc/api/assets/%: doc/api_assets/% out/doc/api/assets
548-
cp $< $@
548+
@cp $< $@
549549

550550
out/doc/%: doc/%
551-
cp -r $< $@
551+
@cp -r $< $@
552552

553553
# check if ./node is actually set, else use user pre-installed binary
554554
gen-json = tools/doc/generate.js --format=json $< > $@
@@ -566,11 +566,11 @@ gen-doc = \
566566
[ -x $(NODE) ] && $(NODE) $(1) || node $(1)
567567

568568
out/doc/api/%.json: doc/api/%.md
569-
$(call gen-doc, $(gen-json))
569+
@$(call gen-doc, $(gen-json))
570570

571571
# check if ./node is actually set, else use user pre-installed binary
572572
out/doc/api/%.html: doc/api/%.md
573-
$(call gen-doc, $(gen-html))
573+
@$(call gen-doc, $(gen-html))
574574

575575
docopen: $(apidocs_html)
576576
@$(PYTHON) -mwebbrowser file://$(PWD)/out/doc/api/all.html

tools/doc/generate.js

-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ if (!inputFile) {
5454
throw new Error('No input file specified');
5555
}
5656

57-
console.error('Input file = %s', inputFile);
5857
fs.readFile(inputFile, 'utf8', function(er, input) {
5958
if (er) throw er;
6059
// process the input for @include lines

tools/doc/preprocess.js

-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ function processIncludes(inputFile, input, cb) {
2525
const includes = input.match(includeExpr);
2626
if (includes === null) return cb(null, input);
2727
var errState = null;
28-
console.error(includes);
2928
var incCount = includes.length;
3029
if (incCount === 0) cb(null, input);
3130
includes.forEach(function(include) {

0 commit comments

Comments
 (0)